Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Adds table action to copy filter to clipboard #154311

Merged
merged 12 commits into from
Apr 13, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 4, 2023

Summary

Part of #153753.

  • Adds an action to the analysis results filter to copy a KUERY filter for each row to the clipboard.
  • Consolidates duplicate code for the Discover action into a custom hook.

image

image

Checklist

@walterra walterra self-assigned this Apr 4, 2023
@walterra walterra force-pushed the ml-153753-copy-to-clipboard branch from ec7e735 to 1785098 Compare April 5, 2023 05:56
@walterra walterra added release_note:enhancement :ml v8.8.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Apr 5, 2023
@walterra walterra marked this pull request as ready for review April 5, 2023 08:22
@walterra walterra requested a review from a team as a code owner April 5, 2023 08:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

const copyToClipboardSignificantTermMessage = i18n.translate(
'xpack.aiops.spikeAnalysisTable.linksMenu.copyToClipboardSignificantTermMessage',
{
defaultMessage: 'Copy field/value pair as KUERY filter to clipboard',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these messages should use KUERY or Kuery 🤔

Copy link
Contributor Author

@walterra walterra Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced KUERY filter with KQL syntax to be in line with the wording in the Discover search bar placeholder in 2eafaec.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 479 490 +11
dataVisualizer 319 320 +1
ml 1721 1722 +1
transform 317 318 +1
total +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 766.1KB 766.1KB -22.0B
Unknown metric groups

API count

id before after diff
@kbn/ml-agg-utils 91 93 +2

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@qn895
Copy link
Member

qn895 commented Apr 13, 2023

LGTM 🎉

@walterra walterra merged commit eb7db09 into elastic:main Apr 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2023
@walterra walterra deleted the ml-153753-copy-to-clipboard branch April 13, 2023 15:27
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Apr 19, 2023
…pboard (elastic#154311)

- Adds an action to the analysis results filter to copy a KUERY filter
for each row to the clipboard.
- Consolidates duplicate code for the Discover action into a custom
hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants