[Security Solution][Endpoint] Add additional tests for Policy Response #154505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
…added missing policy response entries
…s customization of output documents)
…tomization of output documents)
…or using new `.custom()` static methods
…electing os type
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
requested review from
dasansol92
and removed request for
ashokaditya
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
dasansol92
approved these changes
Apr 13, 2023
| @@ -0,0 +1,94 @@ | |||
| /* | |||
There was a problem hiding this comment.
Got curious, why is this in the mocked_data folder?
There was a problem hiding this comment.
there was no need to actually have a real endpoint for this test, thus I did not include it in the other endpoint suite. Also, the "real endpoint" test suite does not run in CI (yet 🤞 )
| @@ -0,0 +1,220 @@ | |||
| /* | |||
There was a problem hiding this comment.
Could you add a bit of explanation here about what this file does and how it works?
There was a problem hiding this comment.
Sure. I'll add it in a subsequent PR.
Essentially, it displays a CLI screen that allows you to set a host and then send it a customized policy response action.
| return mergeWith(destinationObj, srcObj, customizer); | ||
| }; | ||
|
|
||
| export class EndpointPolicyResponseGenerator extends BaseDataGenerator { |
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Apr 19, 2023
elastic#154505) ## Summary - Adds Cypress tests to validate that recent Policy response errors are bubbled up and shown in Fleet Agent Details. - Updated Fleet Agent Details display of Integrations with `data-test-subj`'s for testing In support of the above, the following was also introduced: - New standalone `EndpointPolicyResponseGenerator` which also includes one specific method to retrieve a "connect kernel failure" - New data loaders for Endpoint Policy Responses - Endpoint Emulator CLI was enhanced with a new panel that allows sending policy responses to specific endpoints - Added `EndpointMetadataGenerator.custom()` static method - Creates a custom `EndpointMetadataGenerator` subclass based on input arguments. allows for easier customization of generated endpoint hosts - currently supports setting Host OS and Agent version - Like the above, added `EndpointDocGenerator.custom()` which currently allow for setting a custom endpoint generator for use internally - Added `version` and `os` to `indexEndpointHosts` cypress task - new cypress tasks: - `indexEndpointPolicyResponse` - load a policy response - `deleteIndexedEndpointPolicyResponse` - delete previously loaded policy response -
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
Jul 10, 2023
indexing host timeout has been increased in elastic/pull/159518 added in elastic/pull/154505 skipped in elastic/pull/156104
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
Jul 10, 2023
indexing host timeout has been increased in elastic/pull/159518 added in elastic/pull/154505 skipped in elastic/pull/156104
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
Jul 11, 2023
indexing host timeout has been increased in elastic/pull/159518 added in elastic/pull/154505 skipped in elastic/pull/156104
ashokaditya
added a commit
that referenced
this pull request
Jul 11, 2023
## Summary Unskip test that was timing out at indexing test hosts. The timeout has since been increased in /pull/159518 Was added in /pull/154505 and skipped in /pull/156104
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2023
## Summary Unskip test that was timing out at indexing test hosts. The timeout has since been increased in elastic/pull/159518 Was added in elastic/pull/154505 and skipped in elastic/pull/156104 (cherry picked from commit 5d06694)
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2023
# Backport This will backport the following commits from `main` to `8.9`: - [[Defend Workflows] Unskip policy response test (#161588)](#161588) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ashokaditya","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-07-11T11:58:42Z","message":"[Defend Workflows] Unskip policy response test (#161588)\n\n## Summary\r\n\r\nUnskip test that was timing out at indexing test hosts. \r\nThe timeout has since been increased in /pull/159518\r\n\r\nWas added in /pull/154505 and skipped in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.9.0","v8.10.0"],"number":161588,"url":"#161588 Workflows] Unskip policy response test (#161588)\n\n## Summary\r\n\r\nUnskip test that was timing out at indexing test hosts. \r\nThe timeout has since been increased in /pull/159518\r\n\r\nWas added in /pull/154505 and skipped in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#161588 Workflows] Unskip policy response test (#161588)\n\n## Summary\r\n\r\nUnskip test that was timing out at indexing test hosts. \r\nThe timeout has since been increased in /pull/159518\r\n\r\nWas added in /pull/154505 and skipped in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee"}}]}] BACKPORT--> Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
data-test-subj's for testingIn support of the above, the following was also introduced:
EndpointPolicyResponseGeneratorwhich also includes one specific method to retrieve a "connect kernel failure"EndpointMetadataGenerator.custom()static methodEndpointMetadataGeneratorsubclass based on input arguments. allows for easier customization of generated endpoint hostsEndpointDocGenerator.custom()which currently allow for setting a custom endpoint generator for use internallyversionandostoindexEndpointHostscypress taskindexEndpointPolicyResponse- load a policy responsedeleteIndexedEndpointPolicyResponse- delete previously loaded policy response