Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search] Improve the saved query terminology #154517

Merged
merged 8 commits into from
Apr 11, 2023
Merged

[Unified search] Improve the saved query terminology #154517

merged 8 commits into from
Apr 11, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 6, 2023 •
edited
Loading

Summary

Introduces the changes that are mentioned here #153809 (comment)

image

image

image

@stratoula stratoula requested a review from gchaps April 6, 2023 07:36
@stratoula stratoula mentioned this pull request Apr 6, 2023
Closed
@stratoula stratoula added backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks release_note:enhancement v8.8.0 labels Apr 6, 2023
@stratoula stratoula marked this pull request as ready for review April 6, 2023 10:08
@stratoula stratoula requested a review from a team as a code owner April 6, 2023 10:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

gchaps
gchaps reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with selected query feels a little awkward. How about changing it to Load query

@stratoula
Copy link
Contributor Author

@gchaps done
image

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 267.6KB 267.5KB -183.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedSearch 33.6KB 33.6KB -6.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit c23ecea into elastic:main Apr 11, 2023
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Apr 11, 2023
@stratoula @kibanamachine
[Unified search] Improve the saved query terminology (elastic#154517)
9a18718 
## Summary

Introduces the changes that are mentioned here
elastic#153809 (comment)

<img width="481" alt="image"
src="https://user-images.githubusercontent.com/17003240/230306087-6e82bca8-a5c0-4a13-b7d1-b04fca8ac374.png">
<img width="460" alt="image"
src="https://user-images.githubusercontent.com/17003240/230306169-ece13204-da76-495e-b258-4bfea0877118.png">
<img width="315" alt="image"
src="https://user-images.githubusercontent.com/17003240/230306267-955161c4-a5cf-4427-beef-b768dea38c00.png">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stratoula @elasticmachine @kibana-ci @drewdaemon @gchaps @kibanamachine