[SecuritySolution] Use correct queries and filters for prevalence calls #154544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
commented
Apr 6, 2023
Comment on lines
+99
to
+111
| // For fields with multiple values we need add an extra filter that makes sure | ||
| // that only fields that match ALL the values are queried later on. | ||
| let filters: Filter[] = []; | ||
| if (arrayValues.length > 1) { | ||
| filters = [ | ||
| { | ||
| meta: {}, | ||
| query: { | ||
| bool: { | ||
| must: arrayValues.map((value) => ({ term: { [field]: value } })), | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Not sure this logic should apply in cases other than alert prevalence. But I might just leave this here instead of in PrevalenceCell so that in future this logic can be used in other places.
janmonschke
force-pushed
the
fix-prevalence-counts-for-fields-with-multiple-values
branch
from
cb53239
to
1c401fa
Compare
…-ref HEAD~1..HEAD --fix'
janmonschke
added
Team:Threat Hunting:Investigations
…of github.com:janmonschke/kibana into fix-prevalence-counts-for-fields-with-multiple-values
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
michaelolo24
approved these changes
Apr 18, 2023
|
@elasticmachine merge upstream |
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/investigate_in_timeline.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/investigate_in_timeline.cy.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/detection_alerts/investigate_in_timeline.cy.ts
Outdated
Show resolved
Hide resolved
MadameSheema
approved these changes
Apr 19, 2023
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @janmonschke |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 25, 2023
…ls (elastic#154544) ## Summary Bug ticket elastic#131967 describes an issue where the alert prevalence count is not correct for fields that have array values (such as `process.args`). ## Solution Getting the correct count for those fields involved adding more `term` conditions to the prevalence query and the timeline filter. This ensures that only alerts with the *exact* same array values match instead of partial matches as before. https://user-images.githubusercontent.com/68591/231395154-b5a1c968-8308-49fb-a218-f3611f8331c3.mov ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Get approval from the product team --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug ticket #131967 describes an issue where the alert prevalence count is not correct for fields that have array values (such as
process.args).Solution
Getting the correct count for those fields involved adding more
termconditions to the prevalence query and the timeline filter. This ensures that only alerts with the exact same array values match instead of partial matches as before.Screen.Recording.2023-04-12.at.10.11.35.mov
Checklist