[Security Solutions][Endpoint] Use id instead of identifier to get fleet artifact #154810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
release_note:skip
|
@elasticmachine merge upstream |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
approved these changes
Apr 12, 2023
|
@paul-tavares Sure, we have an FTR suite that checks artifacts generation. Will increase the scope to cover that use case. |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
checked it out tried it, LGTM. I added different artifacts across 2 policies and they were generated correctly and Policy responses were always successful
|
kevinlog
approved these changes
Apr 12, 2023
dasansol92
added
release_note:fix
and removed
release_note:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 12, 2023
…eet artifact (elastic#154810) ## Summary Get fleet artifacts by `artifact.id` instead of by `artifact.identifier` before pushing them to the endpoint manifest. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit fbe0243)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 12, 2023
…get fleet artifact (#154810) (#154837) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solutions][Endpoint] Use id instead of identifier to get fleet artifact (#154810)](#154810) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"david.sanchezsoler@elastic.co"},"sourceCommit":{"committedDate":"2023-04-12T15:54:21Z","message":"[Security Solutions][Endpoint] Use id instead of identifier to get fleet artifact (#154810)\n\n## Summary\r\n\r\nGet fleet artifacts by `artifact.id` instead of by `artifact.identifier`\r\nbefore pushing them to the endpoint manifest.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"fbe024306c37bd87d9c2d4a1bab45b89fb148e77","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Defend Workflows","v8.8.0","v8.7.1"],"number":154810,"url":"#154810 Solutions][Endpoint] Use id instead of identifier to get fleet artifact (#154810)\n\n## Summary\r\n\r\nGet fleet artifacts by `artifact.id` instead of by `artifact.identifier`\r\nbefore pushing them to the endpoint manifest.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"fbe024306c37bd87d9c2d4a1bab45b89fb148e77"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#154810 Solutions][Endpoint] Use id instead of identifier to get fleet artifact (#154810)\n\n## Summary\r\n\r\nGet fleet artifacts by `artifact.id` instead of by `artifact.identifier`\r\nbefore pushing them to the endpoint manifest.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"fbe024306c37bd87d9c2d4a1bab45b89fb148e77"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get fleet artifacts by
artifact.idinstead of byartifact.identifierbefore pushing them to the endpoint manifest.