[Security Solution] [Timeline] delete notes #154834
Conversation
kqualters-elastic
added
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
kqualters-elastic
added
the
release_note:feature
|
|
||
| try { | ||
| const frameworkRequest = await buildFrameworkRequest(context, security, request); | ||
| const noteId = request.body?.noteId ?? ''; |
There was a problem hiding this comment.
Thought, if there is no noteId, could we just early return or just throw an error that the page has to be refreshed before the note can be deleted or something?
|
|
||
| const { isFetching } = useDeleteNote(noteToDelete); | ||
| const disableDelete = useMemo(() => { | ||
| return isFetching || noteId == null; |
There was a problem hiding this comment.
So noteId should never be missing in the query then right?
| [addError] | ||
| ); | ||
|
|
||
| return useQuery( |
There was a problem hiding this comment.
I think you want to use useMutation instead of useQuery? Not sure if you'd get weird caching things using useQuery instead of useMutation
There was a problem hiding this comment.
ya thank you, updated
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.8.0
backport:skip
Summary
This pr is a part of work to harden the UX around investigation guides and user/outside of kibana generated content, currently in the form of markdown: #153377 This pr allows users to delete notes associated with a timeline, as invalid or incorrect content can currently be persisted in a timeline, with no way to remove it except to manually remove a hidden saved object that defines the note. An unused interface was removed as part of this, which seemed to indicate adding the ability to delete notes was planned at some point, but never implemented.
Checklist
Delete any items that are not applicable to this PR.