[Dashboard] Editing toolbar update

[cqliu1]

Summary

Related to #144418.
Closes #160800.

This makes all of the buttons in the editor toolbar small/compressed for a slightly sleeker look. These changes only affect the toolbar in Dashboard and don't change the toolbar appearance in Canvas. I've also removed the quick actions and renamed Select type to Add panel.

Before

After

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[Heenawter]

Hmm... Do we want to do this for just Dashboard? It seems out of place that only one app would use a compressed version of the toolbar while all other apps (Canvas, Lens, etc) use the full height buttons 👀 Maybe I misunderstood in our meeting, but I assumed the requests for a compressed layout were referring to horizontal space and not vertical?

[ryankeairns]

While you are in the neighborhood, can we remove that double border between the icon-only set of buttons? It was not there originally and was the result of some other change along the way.

[cqliu1]

While you are in the neighborhood, can we remove that double border between the icon-only set of buttons? It was not there originally and was the result of some other change along the way.

@ryankeairns I'm gonna hold off on merging this until we land on a design for #144418, but I can open a PR just to fix that double border bc it's been bothering me too haha. The border radius also slightly differs between the button group and the rest of the toolbar buttons. I'll see if I can fix that too.

[andreadelrio]

LGTM!

[cqliu1]

@teresaalvarezsoler I've updated the add panel menu order. Is this correct?

[teresaalvarezsoler]

@teresaalvarezsoler I've updated the add panel menu order. Is this correct?
Looks good! Thanks

[ThomThomson]

Great looking and straightforward changes! Tested locally and looked through the code and everything LGTM!

[ThomThomson]

Nice call to have the size here default to medium. That way we don't have to change Canvas at all.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: ecbaf34

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	994.1KB	994.1KB	+60.0B
dashboard	357.3KB	355.6KB	-1.7KB
total			-1.7KB

Unknown metric groups

API count

id	before	after	diff
@kbn/shared-ux-button-toolbar	27	28	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	489	493	+4
total			+6

History

• 💚 Build #140342 succeeded 254ca50
• 💔 Build #139642 failed e837cf3
• 💔 Build #139630 failed 6b43b80
• 💔 Build #139620 failed 2ecbbd0
• 💔 Build #138941 failed 902528f
• 💛 Build #119959 was flaky 6afab5f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream