Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group-by feature in APM rules #155001

Merged
merged 45 commits into from
Apr 25, 2023
Merged

Add group-by feature in APM rules #155001

merged 45 commits into from
Apr 25, 2023

Commits on Apr 16, 2023

  1. add group alerts by feature in apm rules

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    bfaf0cb View commit details
    Browse the repository at this point in the history

  2. fix ci errors

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    d790929 View commit details
    Browse the repository at this point in the history

  3. fix translations errors

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    e351476 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    e76bc4f View commit details
    Browse the repository at this point in the history

  5. fix tests

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    0ca0259 View commit details
    Browse the repository at this point in the history

  6. fix tests

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    02053b7 View commit details
    Browse the repository at this point in the history

  7. fix integration tests

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    66be550 View commit details
    Browse the repository at this point in the history

  8. update snapshot

    @benakansara
    benakansara committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    aebab24 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f295ce7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4419fe8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. add transaction.name in AAD mapping, add transactionName in UI

    @benakansara
    benakansara committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a6cf45d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. update type

    @benakansara
    benakansara committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    bc90ecf View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. remove string from groupBy

    @benakansara
    benakansara committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3bec382 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    85ac15e View commit details
    Browse the repository at this point in the history

  3. simplify logic of using groupBy

    @benakansara
    benakansara committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8b1666a View commit details
    Browse the repository at this point in the history

  4. remove string type from groupBy

    @benakansara
    benakansara committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f718d8c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. remove commented code

    @benakansara
    benakansara committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    dcd1582 View commit details
    Browse the repository at this point in the history

  2. Update x-pack/plugins/apm/public/components/alerting/ui_components/ap… 

    …m_rule_group_by.tsx

Co-authored-by: Katerina Patticha <kate@kpatticha.com>
    @benakansara @kpatticha
    benakansara and kpatticha committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1ff3b95 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    18d04e3 View commit details
    Browse the repository at this point in the history

  4. Update x-pack/plugins/apm/server/routes/alerts/rule_types/error_count… 

    …/register_error_count_rule_type.ts

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
    @benakansara @sorenlouv
    benakansara and sorenlouv committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    435ef9b View commit details
    Browse the repository at this point in the history

  5. remove explicit type

    @benakansara
    benakansara committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    42b3e1a View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. code review changes, refactoring

    @benakansara
    benakansara committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    a69ba12 View commit details
    Browse the repository at this point in the history

  2. renaming transactionName

    @benakansara
    benakansara committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    f35d1b6 View commit details
    Browse the repository at this point in the history

  3. updated comment

    @benakansara
    benakansara committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    adf2cd1 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @benakansara
    benakansara committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    1948f16 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. code review changes

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    47bb2a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    103e50d View commit details
    Browse the repository at this point in the history

  3. add two new group by fields in error count rule

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    e1e6c10 View commit details
    Browse the repository at this point in the history

  4. add error grouping fields to index mapping

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    fd36f7d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    6c553d4 View commit details
    Browse the repository at this point in the history

  6. change error.grouping_name type to keyword

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    31e3c09 View commit details
    Browse the repository at this point in the history

  7. update snapshot

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5fd7ae4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feat/add-groupby-in-apm-rules

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c126029 View commit details
    Browse the repository at this point in the history

  9. Update x-pack/plugins/apm/common/rules/apm_rule_types.ts 

    Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
    @benakansara @sorenlouv
    benakansara and sorenlouv committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    65a507f View commit details
    Browse the repository at this point in the history

  10. update reason message for translation

    @benakansara
    benakansara committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    b7badaa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Update x-pack/plugins/apm/server/routes/alerts/rule_types/error_count… 

    …/register_error_count_rule_type.ts

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
    @benakansara @sorenlouv
    benakansara and sorenlouv committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    42127e0 View commit details
    Browse the repository at this point in the history

  2. update tests

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6f8e6cc View commit details
    Browse the repository at this point in the history

  3. index environment in alert doc also when not defined

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    48a22c5 View commit details
    Browse the repository at this point in the history

  4. update snapshot

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    050dbf5 View commit details
    Browse the repository at this point in the history

  5. always adding predefined group bys

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    546f0cb View commit details
    Browse the repository at this point in the history

  6. remove error.grouping_name groupby in error count rule

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    009ead9 View commit details
    Browse the repository at this point in the history

  7. rename back action variables

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1bde480 View commit details
    Browse the repository at this point in the history

  8. updated tests

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    69af32b View commit details
    Browse the repository at this point in the history

  9. updated tests

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b662a15 View commit details
    Browse the repository at this point in the history

  10. remove hardcoded error grouping key

    @benakansara
    benakansara committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1b1cbe6 View commit details
    Browse the repository at this point in the history