Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inspector] Improve the display when there are many columns #155119

Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 18, 2023

Summary

Fixes #112176

Improves the way the inspector table is rendered when there are multiple columns. I just applied the eui team feedback

Now

image

Before
image

@stratoula stratoula added release_note:fix Feature:Inspector Inspector infrastructure and implementations Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting v8.8.0 labels Apr 18, 2023
@stratoula stratoula marked this pull request as ready for review April 18, 2023 10:40
@stratoula stratoula requested review from a team as code owners April 18, 2023 10:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only

@stratoula stratoula changed the title [Inpector] Improve the display when there are many columns [Inspector] Improve the display when there are many columns Apr 18, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 52.6KB 52.8KB +143.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit dfbb97f into elastic:main Apr 18, 2023
17 checks passed
navarone-feekery pushed a commit to navarone-feekery/kibana that referenced this pull request Apr 18, 2023
…155119)

## Summary

Fixes elastic#112176

Improves the way the inspector table is rendered when there are multiple
columns. I just applied the eui team feedback

**Now**

<img width="1257" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727448-561cd07a-84ec-472f-9968-27631ef9f4f1.png">


**Before**
<img width="875" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727840-24514f38-0a6f-47a3-89ed-adc0bc7ea2f0.png">
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Apr 19, 2023
…155119)

## Summary

Fixes elastic#112176

Improves the way the inspector table is rendered when there are multiple
columns. I just applied the eui team feedback

**Now**

<img width="1257" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727448-561cd07a-84ec-472f-9968-27631ef9f4f1.png">


**Before**
<img width="875" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727840-24514f38-0a6f-47a3-89ed-adc0bc7ea2f0.png">
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
…155119)

## Summary

Fixes elastic#112176

Improves the way the inspector table is rendered when there are multiple
columns. I just applied the eui team feedback

**Now**

<img width="1257" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727448-561cd07a-84ec-472f-9968-27631ef9f4f1.png">


**Before**
<img width="875" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727840-24514f38-0a6f-47a3-89ed-adc0bc7ea2f0.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Inspector Inspector infrastructure and implementations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector table needs a better display when there are multiple columns
4 participants