Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] allow user to predefined their id when they create connector #155392

Merged
merged 7 commits into from
Apr 20, 2023
Merged

[RAM] allow user to predefined their id when they create connector #155392

merged 7 commits into from
Apr 20, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 20, 2023

Summary

allow user to predefined their id when they create connector

Checklist

@XavierM XavierM added release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Apr 20, 2023
@XavierM XavierM requested a review from a team as a code owner April 20, 2023 13:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote
Copy link
Contributor

I spoke with @XavierM offline, the one change to implement in this PR is an error on create if ever the id exists in the list of pre-configured connectors.

mikecote
mikecote approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and changes LGTM! We talked about adding a unit test for the error when a preconfigured connector exists with the same id.

@XavierM XavierM enabled auto-merge (squash) April 20, 2023 20:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 9ac6f58 into elastic:main Apr 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
@XavierM @nikitaindik
[RAM] allow user to predefined their id when they create connector (e…
8a4bcd4 
…lastic#155392)

## Summary

 allow user to predefined their id when they create connector


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
This was referenced May 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XavierM @elasticmachine @mikecote @kibana-ci @kibanamachine