[DOCS] Automate email-params-test.png, add title in connector table rows #155469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:ResponseOps
|
Documentation preview: |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
lcawl
changed the title
lcawl
force-pushed
the
test-email-connector-screenshot
branch
from
52d99bf
to
4bab9ca
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Apr 21, 2023
…ows (elastic#155469) (cherry picked from commit e1b3bc2)
lcawl
added a commit
that referenced
this pull request
Apr 21, 2023
…able rows (#155469) (#155563) # Backport This will backport the following commits from `main` to `8.7`: - [[DOCS] Automate email-params-test.png, add title in connector table rows (#155469)](#155469) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-04-21T19:19:33Z","message":"[DOCS] Automate email-params-test.png, add title in connector table rows (#155469)","sha":"e1b3bc259aecec5aff8e69b837b5723ba215a244","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.8.0"],"number":155469,"url":"#155469 Automate email-params-test.png, add title in connector table rows (#155469)","sha":"e1b3bc259aecec5aff8e69b837b5723ba215a244"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#155469 Automate email-params-test.png, add title in connector table rows (#155469)","sha":"e1b3bc259aecec5aff8e69b837b5723ba215a244"}}]}] BACKPORT-->
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR automates a screenshot in https://www.elastic.co/guide/en/kibana/master/email-action-type.html#email-action-configuration
In order to select a connector from the table in Stack Management > Connectors, I added a
titleattribute to the row, similar to what exists inkibana/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx
Line 356 in 9024206