Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC][Defend Workflows] Response Actions in New Event Flyout #155504

Closed
wants to merge 8 commits into from

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Apr 21, 2023

This PR's goal was to make sure we have no obstacles and can easily migrate when necessary. There are also more changes in comparison to Main, because I did checkout from another PR.

Zrzut ekranu 2023-04-21 o 14 25 17

@tomsonpl tomsonpl self-assigned this Apr 21, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 21, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / CTI Enrichment Displays persisted enrichments on the JSON view
  • [job] [logs] Security Solution Tests #1 / CTI Enrichment Displays persisted enrichments on the JSON view
  • [job] [logs] Security Solution Tests #1 / CTI Enrichment Displays threat indicator details on the threat intel tab
  • [job] [logs] Security Solution Tests #1 / CTI Enrichment Displays threat indicator details on the threat intel tab
  • [job] [logs] Security Solution Tests #1 / CTI Enrichment with additional indicators Displays matched fields from both indicator match rules and investigation time enrichments on Threat Intel tab
  • [job] [logs] Security Solution Tests #1 / CTI Enrichment with additional indicators Displays matched fields from both indicator match rules and investigation time enrichments on Threat Intel tab
  • [job] [logs] FTR Configs #31 / endpoint Response Actions Responder from alerts should show Responder from alert details under alerts list page
  • [job] [logs] FTR Configs #31 / endpoint Response Actions Responder from alerts should show Responder from alert details under alerts list page
  • [job] [logs] Security Solution Tests #1 / Enrichment Custom query rule Should has enrichment fields
  • [job] [logs] Security Solution Tests #1 / Enrichment Custom query rule Should has enrichment fields
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour Completes the tour with action clicks
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour Completes the tour with action clicks
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour Completes the tour with next button clicks
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour Completes the tour with next button clicks
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 3, resets to 3
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 3, resets to 3
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 4, resets to 4
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 4, resets to 4
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 5, resets to 5
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 5, resets to 5
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 6, resets to 5
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 6, resets to 5
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 7, resets to 7
  • [job] [logs] Security Solution Tests #2 / Guided onboarding tour persists tour steps in flyout on flyout toggle step: 7, resets to 7
  • [job] [logs] Security Solution Tests #1 / Investigate in timeline From alerts details flyout "before all" hook for "should open a new timeline from a prevalence field"
  • [job] [logs] Security Solution Tests #1 / Investigate in timeline From alerts details flyout "before all" hook for "should open a new timeline from a prevalence field"
  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 265 264 -1
securitySolution 3826 3832 +6
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.1MB 1.1MB -491.0B
securitySolution 16.0MB 16.0MB +17.1KB
total +16.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 50.3KB 50.3KB -1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 108 107 -1
securitySolution 394 396 +2
total +1

Total ESLint disabled count

id before after diff
osquery 109 108 -1
securitySolution 474 476 +2
total +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants