Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Display additional anomaly jobs in Entity Analytics Dashboard #155520

Merged
merged 4 commits into from Apr 25, 2023
Merged

[Security Solutions] Display additional anomaly jobs in Entity Analytics Dashboard #155520

merged 4 commits into from Apr 25, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Apr 21, 2023 •
edited

issue: https://github.com/elastic/security-team/issues/6161

Summary

  • Adds more hardcoded jobs to the list of jobs displayed on the Notable anomalies table
  • Add pagination to the table
  • Remove the logic that refreshes the table when a job is installed
  • Move enableDataFeed logic to <EnableJob /> and use the response from the API to determine if the job was successfully installed.
  • Recently installed jobs are no longer sorted so users can find the jobs they have just installed.
  • When the page refreshes all jobs are sorted

Apr-21-2023 17-47-28

  • I also replaced the loading spinner with a "Waiting" status when jobs are waiting for machine learning nodes to start because the loading spinner gave the false impression that the table would update at any moment.

Screenshot 2023-04-24 at 11 22 57

TODO

  • Cypress tests

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum force-pushed the siem-explore-6161 branch 4 times, most recently from 7cc300a to 3555927 Compare April 24, 2023 08:43
@machadoum machadoum changed the title Add pagination to Notable anomalies table [Security Solutions] Add pagination to Notable anomalies table Apr 24, 2023
@machadoum machadoum self-assigned this Apr 24, 2023
@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 release_note:enhancement labels Apr 24, 2023
@machadoum machadoum marked this pull request as ready for review April 24, 2023 09:32
@machadoum machadoum requested review from a team as code owners April 24, 2023 09:32
@machadoum machadoum requested a review from xcrzx April 24, 2023 09:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum changed the title [Security Solutions] Add pagination to Notable anomalies table [Security Solutions] Add more jobs and pagination to Notable anomalies table Apr 24, 2023
@machadoum machadoum changed the title [Security Solutions] Add more jobs and pagination to Notable anomalies table [Security Solutions] Display additional anomaly jobs in Entity Analytics Dashboard Apr 24, 2023
semd
semd reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @machadoum the code looks great! I have a couple of small suggestions.
I know we are close to FF and I don't want to block it, let me know what you think.

x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx Outdated Show resolved Hide resolved
.../plugins/security_solution/public/common/components/ml_popover/hooks/use_enable_data_feed.ts Outdated Show resolved Hide resolved
.../plugins/security_solution/public/common/components/ml_popover/hooks/use_enable_data_feed.ts Show resolved Hide resolved
semd
semd approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀 thanks for doing the changes so quickly

@machadoum machadoum force-pushed the siem-explore-6161 branch 2 times, most recently from 23c15a0 to 62c5f07 Compare April 24, 2023 14:15
@machadoum machadoum added the ci:cloud-deploy Create or update a Cloud deployment label Apr 24, 2023
xcrzx
xcrzx approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules Area changes LGTM!

@machadoum machadoum enabled auto-merge (squash) April 24, 2023 15:41
@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 25, 2023 •
edited

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3853 3855 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +2.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 397 400 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 477 480 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 0ecb2cb into elastic:main Apr 25, 2023
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 25, 2023
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
@machadoum @nikitaindik
[Security Solutions] Display additional anomaly jobs in Entity Analyt…
0307486 
…ics Dashboard (elastic#155520)

issue: elastic/security-team#6161
## Summary

* Adds more hardcoded jobs to the list of jobs displayed on the Notable
anomalies table
* Add pagination to the table
* Remove the logic that refreshes the table when a job is installed
* Move enableDataFeed logic to `<EnableJob />` and use the response from
the API to determine if the job was successfully installed.
* Recently installed jobs are no longer sorted so users can find the
jobs they have just installed.
* When the page refreshes all jobs are sorted


![Apr-21-2023
17-47-28](https://user-images.githubusercontent.com/1490444/233953871-e2583aa8-4d7b-402a-aef3-e001dfc7ae18.gif)

* I also replaced the loading spinner with a "Waiting" status when jobs
are waiting for machine learning nodes to start because the loading
spinner gave the false impression that the table would update at any
moment.

<img width="900" alt="Screenshot 2023-04-24 at 11 22 57"
src="https://user-images.githubusercontent.com/1490444/233956148-6c057d7c-7f89-4881-8d5c-88cbc27f9dff.png">


TODO 
- [x] Cypress tests


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcrzx xcrzx xcrzx approved these changes

@semd semd semd approved these changes

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machadoum @elasticmachine @kibana-ci @xcrzx @semd @kibanamachine