-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Grouping - fix null group missing #155763
Merged
Merged
Changes from 19 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
d9746f5
combine updates
stephmilovic 571e06d
fixed it
stephmilovic f481246
2nd approach
stephmilovic a42cb7c
Merge branch 'main' into grouping_more
stephmilovic c5211ac
add sortf
stephmilovic 4d5dbb7
Merge branch 'null_grouping' into grouping_more
stephmilovic 0c57652
fixed
stephmilovic 0ec5ef6
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 0e3a527
messaging for null group
stephmilovic 322e4b9
Merge branch 'grouping_more' of github.com:stephmilovic/kibana into g…
stephmilovic aaec83a
awesome tests
stephmilovic 1cf328b
WIP - better query
stephmilovic 967d70e
tests
stephmilovic b08fb5f
better
stephmilovic d029486
better
stephmilovic a7aaa61
Merge branch 'main' into grouping_more
stephmilovic deb7a03
fix
stephmilovic f7a90c9
add comment
stephmilovic 1547a49
Merge branch 'main' into grouping_more
kibanamachine 89d3a98
Sergi comment 1
stephmilovic dbed7a9
Sergi comment 2
stephmilovic 7f97490
Sergi fix 1
stephmilovic 7c8ac3a
remove nullGroup
stephmilovic db83fe8
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine dbb33cb
fix mock
stephmilovic 75f2037
pr follow up
stephmilovic 88886ab
merge
stephmilovic 12b54a4
fix bad merge
stephmilovic 0d345e0
update link
stephmilovic 5794a3c
Merge branch 'main' into grouping_more
stephmilovic 33b4153
quick test fix
stephmilovic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to be a host query since its more realistic for testing, rule name will not have a null group.