[Security Solution] Fix color coding of severities is different at Entity analytics #156383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
YulNaumenko
reviewed
May 2, 2023
| @@ -14,13 +14,14 @@ import { euiLightVars } from '@kbn/ui-theme'; | |||
|
|
|||
| import { WithHoverActions } from '../../../../../common/components/with_hover_actions'; | |||
| import { RiskSeverity } from '../../../../../../common/search_strategy'; | |||
| import { SEVERITY_COLOR } from '../../../../../overview/components/detection_response/utils'; | |||
|
|
|||
| export const RISK_SEVERITY_COLOUR: { [k in RiskSeverity]: string } = { | |||
| [RiskSeverity.unknown]: euiLightVars.euiColorMediumShade, | |||
There was a problem hiding this comment.
Do we have a SEVERITY_COLOR for this one? Maybe better just to be consistent here and add this one too.
There was a problem hiding this comment.
No, we don't have it. The unknown severity doesn't exist for Alert severity:
YulNaumenko
approved these changes
May 2, 2023
machadoum
force-pushed
the
siem-explore-143043
branch
from
f950b93
to
f856f44
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
…tity analytics (elastic#156383) issue: elastic#143043 ## Summary Fix color coding of severities is different at Entity Analytics by using the same colors of alert severity. **Before:**  **After:**     (cherry picked from commit 7f68428)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
… at Entity analytics (#156383) (#156508) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fix color coding of severities is different at Entity analytics (#156383)](#156383) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T10:46:19Z","message":"[Security Solution] Fix color coding of severities is different at Entity analytics (#156383)\n\nissue: #143043 Summary\r\n\r\nFix color coding of severities is different at Entity Analytics by using\r\nthe same colors of alert severity.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n\r\n\r\n\r\n**After:**\r\n\r\n\r\n\r\n\r\n\r\n","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":156383,"url":"#156383 Solution] Fix color coding of severities is different at Entity analytics (#156383)\n\nissue: #143043 Summary\r\n\r\nFix color coding of severities is different at Entity Analytics by using\r\nthe same colors of alert severity.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n\r\n\r\n\r\n**After:**\r\n\r\n\r\n\r\n\r\n\r\n","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156383","number":156383,"mergeCommit":{"message":"[Security Solution] Fix color coding of severities is different at Entity analytics (#156383)\n\nissue: #143043 Summary\r\n\r\nFix color coding of severities is different at Entity Analytics by using\r\nthe same colors of alert severity.\r\n\r\n**Before:**\r\n\r\n\r\n\r\n\r\n\r\n\r\n**After:**\r\n\r\n\r\n\r\n\r\n\r\n","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf"}}]}] BACKPORT--> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
\r\n\r\n\r\n\r\n\r\n**After:**\r\n\r\n\r\n\r\n\r\n\r\n","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat){kind=link}
![https://user-images.githubusercontent.com/1490444/235681736-609b484c-bd08-4379-b76b-6a47c3a016ba.png)","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156383","number":156383,"mergeCommit":{"message":"[Security](https://user-images.githubusercontent.com/1490444/235681736-609b484c-bd08-4379-b76b-6a47c3a016ba.png)","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156383","number":156383,"mergeCommit":{"message":"[Security){kind=link}
","sha":"7f68428e3457b1720027ee88b3deb722b0151cbf){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #143043
Summary
Fix color coding of severities is different at Entity Analytics by using the same colors of alert severity.
Before:
After: