Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Unsync highlight state between visualizations #156453

Merged
merged 5 commits into from
May 4, 2023
Merged

[SecuritySolution] Unsync highlight state between visualizations #156453

merged 5 commits into from
May 4, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 2, 2023 •
edited by kibanamachine

Summary

issue: #156325

Before

alerts

After

Screen.Recording.2023-05-02.at.22.17.33.mov

Checklist

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 Feature:Lens Charts Security Solution Lens Charts feature labels May 2, 2023
@angorayc angorayc self-assigned this May 2, 2023
@angorayc angorayc requested a review from a team as a code owner May 2, 2023 21:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label May 2, 2023
andrew-goldstein
andrew-goldstein reviewed May 3, 2023
View reviewed changes
...ns/security_solution/public/common/components/visualization_actions/lens_embeddable.test.tsx
@@ -123,4 +123,9 @@ describe('LensEmbeddable', () => {
it('should render with searchSessionId', () => {
expect(mockEmbeddableComponent.mock.calls[0][0].searchSessionId).toEqual(mockSearchSessionId);
});

it('should not sync highlight state between visualizations', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate this test 😄

@andrew-goldstein
Copy link
Contributor

The hover interactions for the charts below work as-expected on the Overview, but still interact on the case page, per the animated gif below:

testing_cases_page

@angorayc angorayc requested a review from a team as a code owner May 4, 2023 09:45
angorayc
angorayc commented May 4, 2023
View reviewed changes
x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/processor.tsx
@@ -53,6 +53,8 @@ const LensMarkDownRendererComponent: React.FC<LensMarkDownRendererProps> = ({
executionContext={{
type: 'cases',
}}
syncTooltips={false}
syncCursor={false}
Copy link
Contributor Author

@angorayc angorayc May 4, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#156453 (comment)

Screen.Recording.2023-05-04.at.10.15.11.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally 👍

@angorayc
Copy link
Contributor Author

angorayc commented May 4, 2023

The hover interactions for the charts below work as-expected on the Overview, but still interact on the case page, per the animated gif below:

testing_cases_page testing_cases_page

I missed the fact that the visualizations in Cases are rendered by a different component in Cases plugin. It should be fine now.

Screen.Recording.2023-05-04.at.10.15.11.mov

js-jankisalvi
js-jankisalvi approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cases changes looks good 👍

x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/processor.tsx
@@ -53,6 +53,8 @@ const LensMarkDownRendererComponent: React.FC<LensMarkDownRendererProps> = ({
executionContext={{
type: 'cases',
}}
syncTooltips={false}
syncCursor={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally 👍

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters "after each" hook for "Changed banner should hide on Reset"
  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters Changed banner should hide on Reset

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 376.9KB 376.9KB +30.0B
securitySolution 9.1MB 9.1MB +502.0B
total +532.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

andrew-goldstein
andrew-goldstein approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angorayc for this fix!
✅ Desk tested locally
LGTM 🚀

@angorayc angorayc merged commit 0e9d84d into elastic:main May 4, 2023
@kibanamachine kibanamachine mentioned this pull request May 4, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
@angorayc
[SecuritySolution] Unsync highlight state between visualizations (ela…
a2caf95 
…stic#156453)

## Summary

issue: elastic#156325

Before

![alerts](https://user-images.githubusercontent.com/4459398/235551083-f101aba4-7a32-41e8-95a0-4cf50dd09005.gif)

After

https://user-images.githubusercontent.com/6295984/235792908-c7832d7f-7424-4d11-b4f7-52acaa0fa7aa.mov

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0e9d84d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 4, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Unsync highlight state between visualizations (
e02d94a 
#156453) (#156719)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Unsync highlight state between visualizations
(#156453)](#156453)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-04T17:30:14Z","message":"[SecuritySolution]
Unsync highlight state between visualizations (#156453)\n\n##
Summary\r\n\r\nissue:
#156325
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0e9d84d191a660bae8014d9e543fd4b06d71614c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Lens
Charts","v8.9.0"],"number":156453,"url":"#156453
Unsync highlight state between visualizations (#156453)\n\n##
Summary\r\n\r\nissue:
#156325
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0e9d84d191a660bae8014d9e543fd4b06d71614c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156453
Unsync highlight state between visualizations (#156453)\n\n##
Summary\r\n\r\nissue:
#156325
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0e9d84d191a660bae8014d9e543fd4b06d71614c"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@angorayc @elasticmachine @andrew-goldstein @kibana-ci @kibanamachine @js-jankisalvi