[Input Controls] Hide ability to create legacy input controls

[Heenawter]

Closes #150639

Note
The attached issue mentions possibly preventing legacy input control panels from being cloned - while I understand the reasoning for this (if we allow cloning, aren't we essentially still giving users a roundabout way to create new legacy input controls?), I think that the primary goal of this should be to make legacy input controls more difficult to access, not necessarily to prevent users from creating legacy input controls entirely.

After all, if we went to prevent any new legacy input controls from being created, wouldn't we also have to prevent users from cloning existing dashboards that have at least one legacy input control? I think that simply hiding them from the creation menus is a good enough beginning step until we can finally remove them for good.

Summary

This PR takes another step forward in the deprecation process of the legacy input controls by hiding them from the visualization wizard + the visualization creation menu by marking the input_control_vis type as hidden.

Visualize Wizard

Before	After

Note
As a follow up, the visualize team will be removing the visualize:enableLabs setting, since it is used exclusively to hide the controls from this wizard; however, because this PR hides them from this wizard via the hidden property, this setting is now obsolete.

Creation Menu in Dashboard

Before	After

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[stratoula]

Visualizations changes LGTM!

[stratoula]

Visualizations changes LGTM!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 52a137a

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
visualizations	775	776	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visualizations	260.2KB	260.2KB	+11.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
inputControlVis	5.5KB	5.5KB	+10.0B

Unknown metric groups

API count

id	before	after	diff
visualizations	805	806	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
securitySolution	399	403	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
securitySolution	479	483	+4
total			+6

History

• 💛 Build #126230 was flaky c0f64bf
• 💚 Build #125993 succeeded 218cf23
• 💚 Build #125966 succeeded 034b139
• 💔 Build #125945 failed 27b9430
• 💔 Build #124986 failed 320a8d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

[ThomThomson]

Looked through the code and tested this locally and everything LGTM!

It's important to note that you can still access the Legacy Input Controls by navigating directly to the URL {baseURL}/app/visualize#/create?type=input_control_vis, which I'd consider a good thing seeing as we haven't yet covered the entirety of the feature set from the legacy controls.

[ThomThomson]

Smart to add the Input Control to kbn archiver so that the test doesn't have to create one. Nice!

[gaby]

@Heenawter What is replacing the legacy input controls? All our dashboards use this visualization to allow users to filter data based on multiple predefined fields.

[Heenawter]

@gaby They are being replaced by the new input controls, which are much more powerful - you can find the documentation for these here :)

[gaby]

@gaby They are being replaced by the new input controls, which are much more powerful - you can find the documentation for these here :)

Thank you!