-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Prebuilt Security Rules Changelog Reference #156716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense and LGTM, however I don't see any references for this being used in the app when searching for the ruleChangeLog
key. Is this intended to update an existing link in the app, or just as used within the docs over in:
kibana/api_docs/kbn_doc_links.devdocs.json
Lines 527 to 540 in 8181b0c
{ | |
"parentPluginId": "@kbn/doc-links", | |
"id": "def-common.DocLinks.siem", | |
"type": "Object", | |
"tags": [], | |
"label": "siem", | |
"description": [], | |
"signature": [ | |
"{ readonly privileges: string; readonly guide: string; readonly gettingStarted: string; readonly ml: string; readonly ruleChangeLog: string; readonly detectionsReq: string; readonly networkMap: string; readonly troubleshootGaps: string; readonly ruleApiOverview: string; }" | |
], | |
"path": "packages/kbn-doc-links/src/types.ts", | |
"deprecated": false, | |
"trackAdoption": false | |
}, |
Approving for now, but let me know if you want to update any links within Kibana and happy to take another look 🙂
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Also, if we need to target |
@spong - The Re-create:
POST kbn:/api/fleet/epm/packages/security_detection_engine/8.6.1
{
"force": true
}
|
Something must've been up with my IDE when I was checking this, as I'm seeing the reference fine now. It's over in Line 50 in 21de750
So we should be all good here! Sorry for the confusion @terrancedejesus, and thanks for verifying! 🙂 |
Fantastic, glad we got it squared away and thank you for always taking the time to review! |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Summary This PR changes the URL reference link from Kibana UI to downloadable updates security docs site. The current link directs the user to the security doc updates that relate to file system rule updates, which is now deprecated. This update would point the user to the downloadable OOB package updates which is how we currently release prebuilt rules. Existing: https://www.elastic.co/guide/en/security/master/prebuilt-rules-changelog.html (docs built from filesystem rules - deprecated) Proposed: https://www.elastic.co/guide/en/security/master/prebuilt-rules-downloadable-updates.html (aligns with OOB packages - currently how we release and build docs)
Summary
This PR changes the URL reference link from Kibana UI to downloadable updates security docs site. The current link directs the user to the security doc updates that relate to file system rule updates, which is now deprecated. This update would point the user to the downloadable OOB package updates which is how we currently release prebuilt rules.
Existing: https://www.elastic.co/guide/en/security/master/prebuilt-rules-changelog.html (docs built from filesystem rules - deprecated)
Proposed: https://www.elastic.co/guide/en/security/master/prebuilt-rules-downloadable-updates.html (aligns with OOB packages - currently how we release and build docs)