Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped Bulk Actions in Alerts Table tests #156795

Merged
merged 1 commit into from
May 5, 2023

Conversation

jcger
Copy link
Contributor

@jcger jcger commented May 5, 2023

Summary

Fixes #154970
Fixes #152176

Run times before:
Screenshot 12

Run times after:
Screenshot

@jcger jcger added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0 labels May 5, 2023
@jcger jcger requested a review from a team as a code owner May 5, 2023 07:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #22 / expressions explorer emits an action and navigates
  • [job] [logs] FTR Configs #55 / visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jcger jcger merged commit 8325b0d into elastic:main May 5, 2023
27 checks passed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 5, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix skipped Bulk Actions in Alerts Table tests
(#156795)](#156795)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-05T15:04:20Z","message":"Fix
skipped Bulk Actions in Alerts Table tests (#156795)\n\n##
Summary\r\n\r\nFixes
#154970
#152176 times
before:\r\n![Screenshot\r\n12](https://user-images.githubusercontent.com/17549662/236402240-5be77baa-c35b-44f2-bbe1-f49d7cd6accc.png)\r\n\r\nRun
times
after:\r\n\r\n![Screenshot](https://user-images.githubusercontent.com/17549662/236402290-0d7377b2-1db3-4c62-8164-ff40358aea63.png)","sha":"8325b0d01451bce2ddbe1418fbb751a744eff96d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156795,"url":"https://github.com/elastic/kibana/pull/156795","mergeCommit":{"message":"Fix
skipped Bulk Actions in Alerts Table tests (#156795)\n\n##
Summary\r\n\r\nFixes
#154970
#152176 times
before:\r\n![Screenshot\r\n12](https://user-images.githubusercontent.com/17549662/236402240-5be77baa-c35b-44f2-bbe1-f49d7cd6accc.png)\r\n\r\nRun
times
after:\r\n\r\n![Screenshot](https://user-images.githubusercontent.com/17549662/236402290-0d7377b2-1db3-4c62-8164-ff40358aea63.png)","sha":"8325b0d01451bce2ddbe1418fbb751a744eff96d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156795","number":156795,"mergeCommit":{"message":"Fix
skipped Bulk Actions in Alerts Table tests (#156795)\n\n##
Summary\r\n\r\nFixes
#154970
#152176 times
before:\r\n![Screenshot\r\n12](https://user-images.githubusercontent.com/17549662/236402240-5be77baa-c35b-44f2-bbe1-f49d7cd6accc.png)\r\n\r\nRun
times
after:\r\n\r\n![Screenshot](https://user-images.githubusercontent.com/17549662/236402290-0d7377b2-1db3-4c62-8164-ff40358aea63.png)","sha":"8325b0d01451bce2ddbe1418fbb751a744eff96d"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment