Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add Search Bar to Security D&R and EA Dashboards #156832

Merged
merged 12 commits into from May 8, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented May 5, 2023

More details on the issue: https://github.com/elastic/security-team/issues/6504

TODO

Summary

  • Add global search bar and filter to EA and D&R pages.
  • Create useGlobalFilterQuery hook to simplify adding global search bar filters to a page
  • Filter alert column in risk table by time range

May-05-2023 15-12-34
May-05-2023 15-13-42

Screenshot 2023-05-08 at 13 27 54

Tooltips explaining that some pages are not affected by the KQL search bar (Last minute addition)

Screenshot 2023-05-08 at 17 57 32

Screenshot 2023-05-08 at 17 57 37

Screenshot 2023-05-08 at 17 57 51

Screenshot 2023-05-08 at 19 44 20

Screenshot 2023-05-08 at 19 45 21

Glossary

  • EA: Entity Analytics
  • D&R: Detection & Response

Checklist

@machadoum machadoum changed the title Siem explore 6504 [Security Solution] Add Search Bar to Security D&R and EA Dashboards May 5, 2023
@machadoum machadoum self-assigned this May 5, 2023
@machadoum machadoum added release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 ci:cloud-deploy Create or update a Cloud deployment labels May 5, 2023
@machadoum machadoum marked this pull request as ready for review May 8, 2023 14:03
@machadoum machadoum requested review from a team as code owners May 8, 2023 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd self-requested a review May 8, 2023 14:37
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@machadoum machadoum enabled auto-merge (squash) May 8, 2023 17:47
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 8, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3865 3866 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +2.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 7fd9ca6 into elastic:main May 8, 2023
20 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2023
…lastic#156832)

More details on the issue:
elastic/security-team#6504
## TODO

- [x] Unit tests
- [ ] Cypress tests (follow-up PR)

## Summary

* Add global search bar and filter to EA and D&R pages.
* Create `useGlobalFilterQuery` hook to simplify adding global search
bar filters to a page
* Filter alert column in risk table by time range

![May-05-2023
15-12-34](https://user-images.githubusercontent.com/1490444/236467186-f6e6c435-447b-41f4-a6b6-8bd4a3deb498.gif)
![May-05-2023
15-13-42](https://user-images.githubusercontent.com/1490444/236467191-df8cc05a-3c0c-4f37-929f-4d7723e23055.gif)

<img width="1402" alt="Screenshot 2023-05-08 at 13 27 54"
src="https://user-images.githubusercontent.com/1490444/236812677-e6021d99-4be1-44d7-8449-26f9330d8b78.png">

### Tooltips explaining that some pages are not affected by the KQL
search bar (Last minute addition)

<img width="747" alt="Screenshot 2023-05-08 at 17 57 32"
src="https://user-images.githubusercontent.com/1490444/236871990-3ebd60fa-ea45-4f98-a8d9-5813ac2b10de.png">
<img width="1512" alt="Screenshot 2023-05-08 at 17 57 37"
src="https://user-images.githubusercontent.com/1490444/236871998-94969be6-b194-4d19-b83e-12f9b96eda1b.png">
<img width="1512" alt="Screenshot 2023-05-08 at 17 57 51"
src="https://user-images.githubusercontent.com/1490444/236872002-5255f799-f30b-44f1-bd90-8f19037b6915.png">

### Glossary
* **EA:** Entity Analytics
* **D&R:** Detection & Response

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7fd9ca6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 9, 2023
…oards (#156832) (#157115)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Add Search Bar to Security D&R and EA Dashboards
(#156832)](#156832)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T23:58:14Z","message":"[Security
Solution] Add Search Bar to Security D&R and EA Dashboards
(#156832)\n\nMore details on the
issue:\r\nhttps://github.com/elastic/security-team/issues/6504\r\n##
TODO\r\n\r\n- [x] Unit tests\r\n- [ ] Cypress tests (follow-up
PR)\r\n\r\n\r\n\r\n## Summary\r\n\r\n* Add global search bar and filter
to EA and D&R pages.\r\n* Create `useGlobalFilterQuery` hook to simplify
adding global search\r\nbar filters to a page\r\n* Filter alert column
in risk table by time range
\r\n\r\n\r\n![May-05-2023\r\n15-12-34](https://user-images.githubusercontent.com/1490444/236467186-f6e6c435-447b-41f4-a6b6-8bd4a3deb498.gif)\r\n![May-05-2023\r\n15-13-42](https://user-images.githubusercontent.com/1490444/236467191-df8cc05a-3c0c-4f37-929f-4d7723e23055.gif)\r\n\r\n<img
width=\"1402\" alt=\"Screenshot 2023-05-08 at 13 27
54\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236812677-e6021d99-4be1-44d7-8449-26f9330d8b78.png\">\r\n\r\n###
Tooltips explaining that some pages are not affected by the
KQL\r\nsearch bar (Last minute addition)\r\n\r\n<img width=\"747\"
alt=\"Screenshot 2023-05-08 at 17 57
32\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871990-3ebd60fa-ea45-4f98-a8d9-5813ac2b10de.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
37\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871998-94969be6-b194-4d19-b83e-12f9b96eda1b.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
51\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236872002-5255f799-f30b-44f1-bd90-8f19037b6915.png\">\r\n\r\n\r\n###
Glossary\r\n* **EA:** Entity Analytics\r\n* **D&R:** Detection &
Response\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7fd9ca64b0fe99122584fa134e89c1abab9df613","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","ci:cloud-deploy","v8.8.0","v8.9.0"],"number":156832,"url":"#156832
Solution] Add Search Bar to Security D&R and EA Dashboards
(#156832)\n\nMore details on the
issue:\r\nhttps://github.com/elastic/security-team/issues/6504\r\n##
TODO\r\n\r\n- [x] Unit tests\r\n- [ ] Cypress tests (follow-up
PR)\r\n\r\n\r\n\r\n## Summary\r\n\r\n* Add global search bar and filter
to EA and D&R pages.\r\n* Create `useGlobalFilterQuery` hook to simplify
adding global search\r\nbar filters to a page\r\n* Filter alert column
in risk table by time range
\r\n\r\n\r\n![May-05-2023\r\n15-12-34](https://user-images.githubusercontent.com/1490444/236467186-f6e6c435-447b-41f4-a6b6-8bd4a3deb498.gif)\r\n![May-05-2023\r\n15-13-42](https://user-images.githubusercontent.com/1490444/236467191-df8cc05a-3c0c-4f37-929f-4d7723e23055.gif)\r\n\r\n<img
width=\"1402\" alt=\"Screenshot 2023-05-08 at 13 27
54\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236812677-e6021d99-4be1-44d7-8449-26f9330d8b78.png\">\r\n\r\n###
Tooltips explaining that some pages are not affected by the
KQL\r\nsearch bar (Last minute addition)\r\n\r\n<img width=\"747\"
alt=\"Screenshot 2023-05-08 at 17 57
32\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871990-3ebd60fa-ea45-4f98-a8d9-5813ac2b10de.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
37\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871998-94969be6-b194-4d19-b83e-12f9b96eda1b.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
51\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236872002-5255f799-f30b-44f1-bd90-8f19037b6915.png\">\r\n\r\n\r\n###
Glossary\r\n* **EA:** Entity Analytics\r\n* **D&R:** Detection &
Response\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7fd9ca64b0fe99122584fa134e89c1abab9df613"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156832
Solution] Add Search Bar to Security D&R and EA Dashboards
(#156832)\n\nMore details on the
issue:\r\nhttps://github.com/elastic/security-team/issues/6504\r\n##
TODO\r\n\r\n- [x] Unit tests\r\n- [ ] Cypress tests (follow-up
PR)\r\n\r\n\r\n\r\n## Summary\r\n\r\n* Add global search bar and filter
to EA and D&R pages.\r\n* Create `useGlobalFilterQuery` hook to simplify
adding global search\r\nbar filters to a page\r\n* Filter alert column
in risk table by time range
\r\n\r\n\r\n![May-05-2023\r\n15-12-34](https://user-images.githubusercontent.com/1490444/236467186-f6e6c435-447b-41f4-a6b6-8bd4a3deb498.gif)\r\n![May-05-2023\r\n15-13-42](https://user-images.githubusercontent.com/1490444/236467191-df8cc05a-3c0c-4f37-929f-4d7723e23055.gif)\r\n\r\n<img
width=\"1402\" alt=\"Screenshot 2023-05-08 at 13 27
54\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236812677-e6021d99-4be1-44d7-8449-26f9330d8b78.png\">\r\n\r\n###
Tooltips explaining that some pages are not affected by the
KQL\r\nsearch bar (Last minute addition)\r\n\r\n<img width=\"747\"
alt=\"Screenshot 2023-05-08 at 17 57
32\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871990-3ebd60fa-ea45-4f98-a8d9-5813ac2b10de.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
37\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236871998-94969be6-b194-4d19-b83e-12f9b96eda1b.png\">\r\n<img
width=\"1512\" alt=\"Screenshot 2023-05-08 at 17 57
51\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/236872002-5255f799-f30b-44f1-bd90-8f19037b6915.png\">\r\n\r\n\r\n###
Glossary\r\n* **EA:** Entity Analytics\r\n* **D&R:** Detection &
Response\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7fd9ca64b0fe99122584fa134e89c1abab9df613"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants