SavedObjectsRepository code cleanup (bis) #157363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
pgayvallet
added
Team:Core
pgayvallet
commented
May 12, 2023
Comment on lines
-50
to
-51
| // BEWARE: The SavedObjectClient depends on the implementation details of the SavedObjectsRepository | ||
| // so any breaking changes to this repository are considered breaking changes to the SavedObjectsClient. |
There was a problem hiding this comment.
NIT: removed those comments because they didn't really bring any value (and the original comment from the repository file was removed in the previous PR)
Comment on lines
-48
to
-51
| return [...acc, ...sourceFields.map((f) => `${t}.${f}`)]; | ||
| acc.push(...sourceFields.map((f) => `${t}.${f}`)); | ||
| return acc; | ||
| }, []) | ||
| .concat(ROOT_FIELDS) | ||
| .concat(fields); // v5 compatibility |
There was a problem hiding this comment.
So this is the only behavioral change from the PR: I removed the 'v5' compatibility from the time the type fields were at the top level. (this should have been removed years ago...)
| @@ -3792,7 +3792,6 @@ describe('SavedObjectsRepository', () => { | |||
| 'updated_at', | |||
| 'created_at', | |||
| 'originId', | |||
| 'title', | |||
There was a problem hiding this comment.
See previous comment (on the v5 field compat) for the reason of this test change
|
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
approved these changes
May 12, 2023
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
## Summary Follow-up of #157154 Continue the cleanup started in the previous PR, by moving more things around. - Move everything search-related (dsl, aggregations, kql utils) to a dedicated `search` folder - Move a few more things to `/apis/internals` - Remove the 'v5' field compatibility in the field list generation (see comment) - Cleanup some files a bit. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #157154
Continue the cleanup started in the previous PR, by moving more things around.
searchfolder/apis/internals