Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] [Serverless] Disable Agent ID verification for Observability projects #157400

Merged
merged 3 commits into from
May 12, 2023

Conversation

gsantoro
Copy link
Contributor

Summary

We want to disable agentIdVerification to get rid of the final pipeline for the o11y project type in the serverless solution

Checklist

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gsantoro gsantoro requested a review from a team as a code owner May 11, 2023 16:22
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@gsantoro gsantoro self-assigned this May 11, 2023
@gsantoro gsantoro added backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes v8.9.0 labels May 11, 2023
@kpollich kpollich changed the title disable agentIdVerification [Fleet] [Serverless] Disable Agent ID verification for Observability projects May 11, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gsantoro

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gsantoro gsantoro merged commit 8df9c04 into elastic:main May 12, 2023
@gsantoro gsantoro deleted the feature/remove_final_pipeline branch May 12, 2023 11:40
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
…projects (#157400)

## Summary

We want to disable agentIdVerification to get rid of the final pipeline
for the o11y project type in the serverless solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants