Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Response Ops] Alert Table column metadata does not have the columns data type #157653

Merged
merged 4 commits into from May 15, 2023
Merged

[Security Solution][Response Ops] Alert Table column metadata does not have the columns data type #157653

merged 4 commits into from May 15, 2023

Conversation

logeekal
Copy link
Contributor

@logeekal logeekal commented May 12, 2023 •
edited by kibanamachine

Summary

Handles : #157463

  • @timestamp Sorting is working functionally instead of A-Z it should be Old - New
Before After
image
Screen.Recording.2023-05-12.at.22.23.40.mov

Image-After
image

@logeekal logeekal added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0 v8.9.0 labels May 12, 2023
@logeekal logeekal requested a review from a team May 12, 2023 20:27
@logeekal logeekal self-assigned this May 12, 2023
@logeekal logeekal requested a review from a team as a code owner May 12, 2023 20:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@logeekal logeekal added v8.8.1 and removed v8.8.0 labels May 15, 2023
@logeekal logeekal enabled auto-merge (squash) May 15, 2023 09:02
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +62.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

@logeekal logeekal merged commit 1fd03ca into elastic:main May 15, 2023
18 checks passed
@kibanamachine kibanamachine mentioned this pull request May 15, 2023
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 15, 2023
@logeekal
[Security Solution][Response Ops] Alert Table column metadata does no…
4177a41 
…t have the columns data type (elastic#157653)

## Summary

Handles : elastic#157463

- `@timestamp` Sorting is working functionally instead of `A-Z` it
should be `Old - New`

|Before|After|
|---|---|

|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video
src="https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870"
/>|

Image-After
<img width="611" alt="image"
src="https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8">

(cherry picked from commit 1fd03ca)
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@logeekal @jasonrhodes
[Security Solution][Response Ops] Alert Table column metadata does no…
83ef4e8 
…t have the columns data type (#157653)

## Summary

Handles : #157463 

- `@timestamp` Sorting is working functionally instead of `A-Z` it
should be `Old - New`

|Before|After|
|---|---|

|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video
src="https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870"
/>|

Image-After
<img width="611" alt="image"
src="https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8">
logeekal added a commit to logeekal/kibana that referenced this pull request Jun 2, 2023
@logeekal
[Security Solution][Response Ops] Alert Table column metadata does no…
792c492 
…t have the columns data type (elastic#157653)

## Summary

Handles : elastic#157463

- `@timestamp` Sorting is working functionally instead of `A-Z` it
should be `Old - New`

|Before|After|
|---|---|

|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video
src="https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870"
/>|

Image-After
<img width="611" alt="image"
src="https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8">

(cherry picked from commit 1fd03ca)
@logeekal logeekal mentioned this pull request Jun 2, 2023
Merged
@logeekal
Copy link
Contributor Author

logeekal commented Jun 2, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

logeekal added a commit that referenced this pull request Jun 2, 2023
@logeekal
[8.8] [Security Solution][Response Ops] Alert Table column metadata d…
80d17c6 
…oes not have the columns data type (#157653) (#158907)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Response Ops] Alert Table column metadata does
not have the columns data type
(#157653)](#157653)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T09:59:57Z","message":"[Security
Solution][Response Ops] Alert Table column metadata does not have the
columns data type (#157653)\n\n## Summary\r\n\r\nHandles : #157463
\r\n\r\n- `@timestamp` Sorting is working functionally instead of `A-Z`
it\r\nshould be `Old -
New`\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870\"\r\n/>|\r\n\r\nImage-After\r\n<img
width=\"611\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8\">","sha":"1fd03ca9a80b85cc61ddd506e96eb316b8a9984f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Team:Threat
Hunting:Investigations","v8.9.0","v8.8.1"],"number":157653,"url":"#157653
Solution][Response Ops] Alert Table column metadata does not have the
columns data type (#157653)\n\n## Summary\r\n\r\nHandles : #157463
\r\n\r\n- `@timestamp` Sorting is working functionally instead of `A-Z`
it\r\nshould be `Old -
New`\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870\"\r\n/>|\r\n\r\nImage-After\r\n<img
width=\"611\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8\">","sha":"1fd03ca9a80b85cc61ddd506e96eb316b8a9984f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157653","number":157653,"mergeCommit":{"message":"[Security
Solution][Response Ops] Alert Table column metadata does not have the
columns data type (#157653)\n\n## Summary\r\n\r\nHandles : #157463
\r\n\r\n- `@timestamp` Sorting is working functionally instead of `A-Z`
it\r\nshould be `Old -
New`\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|![image](https://github.com/elastic/kibana/assets/59917825/6c5a4c64-cd74-4421-af16-f6172bfc7fc5)|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/15ac8a52-eece-4892-8c32-09f19e18e870\"\r\n/>|\r\n\r\nImage-After\r\n<img
width=\"611\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/b9f62366-3067-4a74-b7be-74fb8f94d2b8\">","sha":"1fd03ca9a80b85cc61ddd506e96eb316b8a9984f"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@logeekal logeekal

Labels
release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.1 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@logeekal @elasticmachine @kibana-ci @kibanamachine @XavierM @michaelolo24