Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] remove kbn-alerts package (unused.) #157737

Merged
merged 3 commits into from
May 15, 2023

Conversation

oatkiller
Copy link
Contributor

Summary

Remove the unused kbn-alerts package

For maintainers

Remove the unused kbn-alerts package
@oatkiller oatkiller added the release_note:skip Skip the PR/issue when compiling release notes label May 15, 2023
@oatkiller oatkiller requested a review from a team May 15, 2023 14:25
@oatkiller oatkiller requested a review from a team as a code owner May 15, 2023 14:25
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerts 9 - -9

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/alerts 1 - -1
Unknown metric groups

API count

id before after diff
@kbn/alerts 9 - -9

ESLint disabled line counts

id before after diff
@kbn/alerts 2 - -2
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +4

Total ESLint disabled count

id before after diff
@kbn/alerts 2 - -2
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller requested a review from yctercero May 15, 2023 17:26
@oatkiller
Copy link
Contributor Author

@yctercero Hi, I believe you might have created this package. I am working to ensure we have clear codeowners for all code (and especially tests.) This package wasn't owned by a specific Security team. When I looked into places where it was being used, I couldn't find any. I believe this code is unused so I am proposing that we remove it. Thanks for your time.

@oatkiller oatkiller enabled auto-merge (squash) May 15, 2023 19:40
@yctercero
Copy link
Contributor

@yctercero Hi, I believe you might have created this package. I am working to ensure we have clear codeowners for all code (and especially tests.) This package wasn't owned by a specific Security team. When I looked into places where it was being used, I couldn't find any. I believe this code is unused so I am proposing that we remove it. Thanks for your time.

Thanks @oatkiller ! I can't recall adding it, though I believe it was for the RAC rbac work. Definitely great to delete unused code.

@oatkiller oatkiller merged commit 0c88d3a into elastic:main May 15, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 15, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
## Summary

Remove the unused kbn-alerts package

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants