[optimizer] run webpack compilation ASAP (no more laziness) #15795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Is it expected for this to to always optimize on save (vs when a file is changed)? |
|
I think so, if the modified timestamp is updated it will probably trigger a rebuild |
jbudz
approved these changes
Jan 8, 2018
tylersmalley
approved these changes
Jan 9, 2018
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jan 9, 2018
…15795) * [optimizer] run webpack compilation ASAP (no more laziness) * [optimize] fix variable reference
|
6.1/6.x: ccb7949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "lazy" optimizer currently delays compilation until a request for build output is received. This prevents webpack from compiling constantly in the background, but also makes refresh times slower. Several people have said that they would prefer it be done the other way around, and just about every other watching compiler does it this way, so this pr removes that feature.
Changes will now immediately trigger a compilation and refreshes will be a little faster because compilation will either be complete or in progress before the refresh is actually started.