[SLO] Adding Data Views to index pattern selector #158033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:enhancement
Team: Actionable Observability - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
simianhacker
changed the title
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
## Summary This PR adds support for picking Data Views to the index selector for the Custom KQL indicator. However, this doesn't actually attach the Data View to the SLO definition, this is only a convenient way to re-use the index pattern defined in the Data View. Keep in mind that if a user updates a Data View, they will need to update the SLO as well since the SLO service uses transforms behind the scenes; transforms do not support Kibana Data Views and there isn't a way to detect when the Data View is updated to re-create the transform. This PR also filters out hidden indices OR indices whose names are prefixed with a dot. <img width="953" alt="image" src="https://github.com/elastic/kibana/assets/41702/ef477f63-f89d-4733-aa19-95138d735967">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for picking Data Views to the index selector for the Custom KQL indicator. However, this doesn't actually attach the Data View to the SLO definition, this is only a convenient way to re-use the index pattern defined in the Data View. Keep in mind that if a user updates a Data View, they will need to update the SLO as well since the SLO service uses transforms behind the scenes; transforms do not support Kibana Data Views and there isn't a way to detect when the Data View is updated to re-create the transform.
This PR also filters out hidden indices OR indices whose names are prefixed with a dot.