[Security Solution] Add support for multiple values in cell actions #158060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:fix
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @semd |
stephmilovic
approved these changes
May 18, 2023
There was a problem hiding this comment.
Very clean solution, nicely done. Thank you for the fix. Desk tested with my extra tricky values and everything works perfectly. Awesome work @semd LGTM 🚀
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 18, 2023
…lastic#158060) ## Summary fixes: elastic#157237 closes: elastic#157887 Enables cell actions package to support multi-valuated cells. Actions affected: - Filter In - Filter Out - Add To Timeline - Copy To Clipboard ### Recording https://github.com/elastic/kibana/assets/17747913/a192173d-5fca-4b33-91a7-664ecd71550b #### Caveat The `FilterManager` does not recognize the duplicated filter when using the new `Combined` filters (the ones that allow AND/OR operations), so when adding two opposite combined filters, it does not remove the first one and both are applied at the same time:  (cherry picked from commit 4dd1373)
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
…lastic#158060) ## Summary fixes: elastic#157237 closes: elastic#157887 Enables cell actions package to support multi-valuated cells. Actions affected: - Filter In - Filter Out - Add To Timeline - Copy To Clipboard ### Recording https://github.com/elastic/kibana/assets/17747913/a192173d-5fca-4b33-91a7-664ecd71550b #### Caveat The `FilterManager` does not recognize the duplicated filter when using the new `Combined` filters (the ones that allow AND/OR operations), so when adding two opposite combined filters, it does not remove the first one and both are applied at the same time: 
kibanamachine
added a commit
that referenced
this pull request
Jun 6, 2023
…ions (#158060) (#158104) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Add support for multiple values in cell actions (#158060)](#158060) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2023-05-18T18:49:47Z","message":"[Security Solution] Add support for multiple values in cell actions (#158060)\n\n## Summary\r\n\r\nfixes: #157237: #157887 \r\n\r\nEnables cell actions package to support multi-valuated cells. Actions\r\naffected:\r\n- Filter In\r\n- Filter Out\r\n- Add To Timeline\r\n- Copy To Clipboard\r\n\r\n### Recording\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17747913/a192173d-5fca-4b33-91a7-664ecd71550b\r\n\r\n#### Caveat\r\nThe `FilterManager` does not recognize the duplicated filter when using\r\nthe new `Combined` filters (the ones that allow AND/OR operations), so\r\nwhen adding two opposite combined filters, it does not remove the first\r\none and both are applied at the same time:\r\n\r\n\r\n","sha":"4dd1373571c99540d8ca04846f1e2aeb55fbe80f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting","Team:Threat Hunting:Explore","v8.9.0","v8.8.1"],"number":158060,"url":"#158060 Solution] Add support for multiple values in cell actions (#158060)\n\n## Summary\r\n\r\nfixes: #157237: #157887 \r\n\r\nEnables cell actions package to support multi-valuated cells. Actions\r\naffected:\r\n- Filter In\r\n- Filter Out\r\n- Add To Timeline\r\n- Copy To Clipboard\r\n\r\n### Recording\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17747913/a192173d-5fca-4b33-91a7-664ecd71550b\r\n\r\n#### Caveat\r\nThe `FilterManager` does not recognize the duplicated filter when using\r\nthe new `Combined` filters (the ones that allow AND/OR operations), so\r\nwhen adding two opposite combined filters, it does not remove the first\r\none and both are applied at the same time:\r\n\r\n\r\n\n\n## Summary\r\n\r\nfixes: #157237: #157887 \r\n\r\nEnables cell actions package to support multi-valuated cells. Actions\r\naffected:\r\n- Filter In\r\n- Filter Out\r\n- Add To Timeline\r\n- Copy To Clipboard\r\n\r\n### Recording\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17747913/a192173d-5fca-4b33-91a7-664ecd71550b\r\n\r\n#### Caveat\r\nThe `FilterManager` does not recognize the duplicated filter when using\r\nthe new `Combined` filters (the ones that allow AND/OR operations), so\r\nwhen adding two opposite combined filters, it does not remove the first\r\none and both are applied at the same time:\r\n\r\n\r\n","sha":"4dd1373571c99540d8ca04846f1e2aeb55fbe80f"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
|
This PR backport didn't make it into the latest BC for 8.8.1. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes: #157237
closes: #157887
Enables cell actions package to support multi-valuated cells. Actions affected:
Recording
multivaluated_cell_actions.mov
Caveat
The
FilterManagerdoes not recognize the duplicated filter when using the newCombinedfilters (the ones that allow AND/OR operations), so when adding two opposite combined filters, it does not remove the first one and both are applied at the same time: