Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] fix toolbar action button not filled when selected #158284

Merged
merged 6 commits into from May 26, 2023
Merged

[maps] fix toolbar action button not filled when selected #158284

merged 6 commits into from May 26, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 23, 2023 •
edited by kibanamachine

Fixes #158221

Updated CSS selector to look for any class containing "euiButtonIcon-fill" instead of old "euiButtonIcon--fill". Had to use wild card select because class name as dynamic id in it, for example "css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles"

Now, button is filled and icon is white when selected.
Screen Shot 2023-05-23 at 10 34 42 AM

@nreese nreese marked this pull request as ready for review May 23, 2023 16:39
@nreese nreese requested a review from a team as a code owner May 23, 2023 16:39
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps v8.9.0 labels May 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the v8.8.1 label May 23, 2023
@Heenawter
Copy link
Contributor

FYI this issue also applies to the time slider in the dashboard:

image

Not sure if we want to fix this as part of this PR, or separately?

@nreese
Copy link
Contributor Author

nreese commented May 23, 2023 •
edited

FYI this issue also applies to the time slider in the dashboard:

I am not sure what you mean. The issue is with timeslider button in maps. See circled button (should be filled). What are you referring too?
Screen Shot 2023-05-22 at 3 51 38 PM

@Heenawter
Copy link
Contributor

Woop sorry - I thought this was about the time slider control itself, which is rendering all grey when it should be white:

image

We can fix that separately, sorry about that - should have looked closer 🖖

@nreese
Copy link
Contributor Author

nreese commented May 24, 2023

@elasticmachine merge upstream

@nreese nreese requested a review from a team as a code owner May 24, 2023 17:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +669.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 402 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 482 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jsanz
jsanz approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code changes look good to me.

@nreese nreese merged commit 33f5bb6 into elastic:main May 26, 2023
17 checks passed
@kibanamachine kibanamachine mentioned this pull request May 26, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 26, 2023
@nreese
[maps] fix toolbar action button not filled when selected (elastic#15…
fa96570 
…8284)

Fixes elastic#158221

Updated CSS selector to look for any class containing
"euiButtonIcon-fill" instead of old "euiButtonIcon--fill". Had to use
wild card select because class name as dynamic id in it, for example
"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles"

Now, button is filled and icon is white when selected.
<img width="400" alt="Screen Shot 2023-05-23 at 10 34 42 AM"
src="https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 33f5bb6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 26, 2023
@kibanamachine @nreese
[8.8] [maps] fix toolbar action button not filled when selected (#158284
8c83d40 
) (#158556)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[maps] fix toolbar action button not filled when selected
(#158284)](#158284)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-05-26T12:20:48Z","message":"[maps]
fix toolbar action button not filled when selected (#158284)\n\nFixes
#158221 CSS
selector to look for any class containing\r\n\"euiButtonIcon-fill\"
instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select
because class name as dynamic id in it, for
example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow,
button is filled and icon is white when selected.\r\n<img width=\"400\"
alt=\"Screen Shot 2023-05-23 at 10 34 42
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.9.0","v8.8.1"],"number":158284,"url":"#158284
fix toolbar action button not filled when selected (#158284)\n\nFixes
#158221 CSS
selector to look for any class containing\r\n\"euiButtonIcon-fill\"
instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select
because class name as dynamic id in it, for
example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow,
button is filled and icon is white when selected.\r\n<img width=\"400\"
alt=\"Screen Shot 2023-05-23 at 10 34 42
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#158284
fix toolbar action button not filled when selected (#158284)\n\nFixes
#158221 CSS
selector to look for any class containing\r\n\"euiButtonIcon-fill\"
instead of old \"euiButtonIcon--fill\". Had to use\r\nwild card select
because class name as dynamic id in it, for
example\r\n\"css-1q7ycil-euiButtonIcon-empty-primary-hoverStyles\"\r\n\r\nNow,
button is filled and icon is white when selected.\r\n<img width=\"400\"
alt=\"Screen Shot 2023-05-23 at 10 34 42
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/821d95da-df7a-4779-a7fa-2ce2aa61fa7d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"33f5bb6ba57f533b9ac894f4f6020d6c855ab1ad"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanz jsanz jsanz approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

Assignees
No one assigned
Labels
Feature:Maps release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.1 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] toolbar action button not filled when selected
7 participants
@nreese @elasticmachine @Heenawter @kibana-ci @kibanamachine @jsanz @MichaelMarcialis