Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolutions] Fix anomalies table pagination on EA page #158739

Merged
merged 2 commits into from Jun 2, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented May 31, 2023

issue: #158809

Summary

The anomalies table on the EA page only showed anomalies count data for the 10 first jobs. That happened because the default bucket limit for aggregations is 10. This bug started happening when we added more than 10 jobs to the table.

Before

Jun-01-2023 10-41-01

After
Jun-01-2023 10-48-17

@machadoum machadoum added the ci:cloud-deploy Create or update a Cloud deployment label May 31, 2023
@machadoum machadoum self-assigned this May 31, 2023
@machadoum machadoum added v8.8.1 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore bug Fixes for quality problems that affect the customer experience and removed ci:cloud-deploy Create or update a Cloud deployment labels Jun 1, 2023
@machadoum machadoum marked this pull request as ready for review June 1, 2023 09:23
@machadoum machadoum requested a review from a team as a code owner June 1, 2023 09:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum machadoum changed the title [SecuritySolutions] Fix anomalies table on EA page [SecuritySolutions] Fix anomalies table pagination on EA page Jun 1, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Entity Analytics Dashboard With anomalies data renders table with pagination

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.4MB 9.4MB +9.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 499 503 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 11c4578 into elastic:main Jun 2, 2023
25 checks passed
@machadoum
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 2, 2023
…c#158739)

issue: elastic#158809

## Summary

The anomalies table on the EA page only showed anomalies count data for
the 10 first jobs. That happened because the default bucket limit for
aggregations is 10. This bug started happening when we added more than
10 jobs to the table.

**Before**

![Jun-01-2023
10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)

**After**
![Jun-01-2023
10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11c4578)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

machadoum added a commit to machadoum/kibana that referenced this pull request Jun 2, 2023
…c#158739)

issue: elastic#158809

## Summary

The anomalies table on the EA page only showed anomalies count data for
the 10 first jobs. That happened because the default bucket limit for
aggregations is 10. This bug started happening when we added more than
10 jobs to the table.

**Before**

![Jun-01-2023
10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)

**After**
![Jun-01-2023
10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11c4578)
@machadoum machadoum removed the v8.8.1 label Jun 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 2, 2023
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jun 5, 2023
…c#158739)

issue: elastic#158809


## Summary

The anomalies table on the EA page only showed anomalies count data for
the 10 first jobs. That happened because the default bucket limit for
aggregations is 10. This bug started happening when we added more than
10 jobs to the table.

**Before**

![Jun-01-2023
10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)

**After**
![Jun-01-2023
10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
machadoum added a commit to machadoum/kibana that referenced this pull request Jun 6, 2023
…c#158739)

issue: elastic#158809

## Summary

The anomalies table on the EA page only showed anomalies count data for
the 10 first jobs. That happened because the default bucket limit for
aggregations is 10. This bug started happening when we added more than
10 jobs to the table.

**Before**

![Jun-01-2023
10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)

**After**
![Jun-01-2023
10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11c4578)
@machadoum
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

machadoum added a commit that referenced this pull request Jun 6, 2023
…158739) (#159104)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolutions] Fix anomalies table pagination on EA page
(#158739)](#158739)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T14:26:12Z","message":"[SecuritySolutions]
Fix anomalies table pagination on EA page (#158739)\n\nissue:
#158809
Summary\r\n\r\nThe anomalies table on the EA page only showed anomalies
count data for\r\nthe 10 first jobs. That happened because the default
bucket limit for\r\naggregations is 10. This bug started happening when
we added more than\r\n10 jobs to the
table.\r\n\r\n**Before**\r\n\r\n![Jun-01-2023\r\n10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)\r\n\r\n**After**\r\n![Jun-01-2023\r\n10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11c4578db7fd56a83262b0caa16664eda8d906f7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.9.0","v8.8.2"],"number":158739,"url":"#158739
Fix anomalies table pagination on EA page (#158739)\n\nissue:
#158809
Summary\r\n\r\nThe anomalies table on the EA page only showed anomalies
count data for\r\nthe 10 first jobs. That happened because the default
bucket limit for\r\naggregations is 10. This bug started happening when
we added more than\r\n10 jobs to the
table.\r\n\r\n**Before**\r\n\r\n![Jun-01-2023\r\n10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)\r\n\r\n**After**\r\n![Jun-01-2023\r\n10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11c4578db7fd56a83262b0caa16664eda8d906f7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#158739
Fix anomalies table pagination on EA page (#158739)\n\nissue:
#158809
Summary\r\n\r\nThe anomalies table on the EA page only showed anomalies
count data for\r\nthe 10 first jobs. That happened because the default
bucket limit for\r\naggregations is 10. This bug started happening when
we added more than\r\n10 jobs to the
table.\r\n\r\n**Before**\r\n\r\n![Jun-01-2023\r\n10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)\r\n\r\n**After**\r\n![Jun-01-2023\r\n10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"11c4578db7fd56a83262b0caa16664eda8d906f7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
sloanelybutsurely pushed a commit to sloanelybutsurely/kibana that referenced this pull request Jun 6, 2023
…c#158739)

issue: elastic#158809


## Summary

The anomalies table on the EA page only showed anomalies count data for
the 10 first jobs. That happened because the default bucket limit for
aggregations is 10. This bug started happening when we added more than
10 jobs to the table.

**Before**

![Jun-01-2023
10-41-01](https://github.com/elastic/kibana/assets/1490444/386cd69f-5531-40af-ab12-12476fababaa)

**After**
![Jun-01-2023
10-48-17](https://github.com/elastic/kibana/assets/1490444/afee4d3d-4e19-4dfe-aa84-787c4fab060d)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mistic
Copy link
Member

mistic commented Jun 8, 2023

This PR backport didn't make it into the latest BC for 8.8.1. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.2 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants