Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimizer] allow http caching for bundles #15880

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Commits on Jan 7, 2018

  1. [optimizer] allow http caching for bundles

    By setting cache-control to must-revalidate, we indicate to the browser
    that it should send the if-none-match header with the last known etag
    value. If the etags match, the server responds with a 304 and no body,
    and if they don't the server responds with a 200 and a body along with a
    new etag.
    
    This ensures a cache is always invalidated when a bundle changes, like
    when Kibana is upgraded or a plugin is installed.
    
    We no longer send the last-modified header because we don't want the
    browser caching based on time. Doing so can be unpredictable since the
    browser may not agree with the server's definitions of DST, and the
    server time itself can be changed.
    epixa committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    50cd63e View commit details
    Browse the repository at this point in the history