Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Detection Engine] - Add tour for new eql missing events feature #158863

Merged
merged 3 commits into from
Jun 20, 2023
Merged

[Security Solution] [Detection Engine] - Add tour for new eql missing events feature #158863

merged 3 commits into from
Jun 20, 2023

Conversation

yctercero
Copy link
Contributor

Summary

Adds tour highlighting the new missing events EQL feature for 8.9.

Screenshot 2023-06-01 at 11 36 54 AM

@yctercero yctercero self-assigned this Jun 1, 2023
@yctercero yctercero requested review from a team as code owners June 1, 2023 18:39
@yctercero yctercero requested a review from spong June 1, 2023 18:39
spong
spong approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Rule Mgmt changes LGTM! I haven't implemented a tour yet myself, but these changes LGTM based on our current comments/instructions around tours. Thanks @yctercero!

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@yctercero yctercero added Feature:Detection Rules Anything related to Security Solution's Detection Rules Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:feature Makes this part of the condensed release notes v8.9.0 Team:Detection Engine Security Solution Detection Engine Area labels Jun 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #2 / Detections : Page Filters Alert Page Filters Customization should be able to delete Controls

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4199 4201 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.4KB 51.6KB +122.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 7153359 into elastic:main Jun 20, 2023
24 of 25 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 20, 2023
@vitaliidm vitaliidm mentioned this pull request Oct 16, 2023
Merged
vitaliidm added a commit that referenced this pull request Oct 17, 2023
@vitaliidm
[Security Solution][Detections] adds new feature tour for ES|QL (#168879
6dfc3cc 
)

## Summary

- similarly to #158863, adds
feature tour for 8.11 new rule type ES|QL
- tour is displayed for ESS only, as in Serverless ES|QL is not
supported

### Screenshot

<img width="2550" alt="Screenshot 2023-10-16 at 11 38 45"
src="https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c">
vitaliidm added a commit to vitaliidm/kibana that referenced this pull request Oct 17, 2023
@vitaliidm
[Security Solution][Detections] adds new feature tour for ES|QL (elas…
e7887e2 
…tic#168879)

## Summary

- similarly to elastic#158863, adds
feature tour for 8.11 new rule type ES|QL
- tour is displayed for ESS only, as in Serverless ES|QL is not
supported

### Screenshot

<img width="2550" alt="Screenshot 2023-10-16 at 11 38 45"
src="https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c">

(cherry picked from commit 6dfc3cc)

# Conflicts:
#	x-pack/plugins/security_solution/public/detections/components/rules/select_rule_type/index.test.tsx
#	x-pack/plugins/security_solution/public/detections/components/rules/select_rule_type/index.tsx
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@vitaliidm @dej611
[Security Solution][Detections] adds new feature tour for ES|QL (elas…
d97016e 
…tic#168879)

## Summary

- similarly to elastic#158863, adds
feature tour for 8.11 new rule type ES|QL
- tour is displayed for ESS only, as in Serverless ES|QL is not
supported

### Screenshot

<img width="2550" alt="Screenshot 2023-10-16 at 11 38 45"
src="https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c">
vitaliidm added a commit that referenced this pull request Oct 18, 2023
@vitaliidm @kibanamachine
[8.11] [Security Solution][Detections] adds new feature tour for ES|QL (
efc2aa5 
#168879) (#169080)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution][Detections] adds new feature tour for ES|QL
(#168879)](#168879)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-10-17T08:38:51Z","message":"[Security
Solution][Detections] adds new feature tour for ES|QL (#168879)\n\n##
Summary\r\n\r\n- similarly to
#158863, adds\r\nfeature tour for
8.11 new rule type ES|QL\r\n- tour is displayed for ESS only, as in
Serverless ES|QL is not\r\nsupported\r\n\r\n### Screenshot\r\n\r\n<img
width=\"2550\" alt=\"Screenshot 2023-10-16 at 11 38
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c\">","sha":"6dfc3cccea2445332706af64206ccad848da37ac","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection
Engine","v8.11.0","v8.12.0"],"number":168879,"url":"#168879
Solution][Detections] adds new feature tour for ES|QL (#168879)\n\n##
Summary\r\n\r\n- similarly to
#158863, adds\r\nfeature tour for
8.11 new rule type ES|QL\r\n- tour is displayed for ESS only, as in
Serverless ES|QL is not\r\nsupported\r\n\r\n### Screenshot\r\n\r\n<img
width=\"2550\" alt=\"Screenshot 2023-10-16 at 11 38
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c\">","sha":"6dfc3cccea2445332706af64206ccad848da37ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168879","number":168879,"mergeCommit":{"message":"[Security
Solution][Detections] adds new feature tour for ES|QL (#168879)\n\n##
Summary\r\n\r\n- similarly to
#158863, adds\r\nfeature tour for
8.11 new rule type ES|QL\r\n- tour is displayed for ESS only, as in
Serverless ES|QL is not\r\nsupported\r\n\r\n### Screenshot\r\n\r\n<img
width=\"2550\" alt=\"Screenshot 2023-10-16 at 11 38
45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c\">","sha":"6dfc3cccea2445332706af64206ccad848da37ac"}}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
@vitaliidm @benakansara
[Security Solution][Detections] adds new feature tour for ES|QL (elas…
852c742 
…tic#168879)

## Summary

- similarly to elastic#158863, adds
feature tour for 8.11 new rule type ES|QL
- tour is displayed for ESS only, as in Serverless ES|QL is not
supported

### Screenshot

<img width="2550" alt="Screenshot 2023-10-16 at 11 38 45"
src="https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c">
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
@vitaliidm @benakansara
[Security Solution][Detections] adds new feature tour for ES|QL (elas…
0fed43f 
…tic#168879)

## Summary

- similarly to elastic#158863, adds
feature tour for 8.11 new rule type ES|QL
- tour is displayed for ESS only, as in Serverless ES|QL is not
supported

### Screenshot

<img width="2550" alt="Screenshot 2023-10-16 at 11 38 45"
src="https://github.com/elastic/kibana/assets/92328789/fe229bf9-9ea8-4016-8e06-42374652c48c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@yctercero yctercero

Labels
backport:skip This commit does not require backporting Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:feature Makes this part of the condensed release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yctercero @kibanamachine @elasticmachine @kibana-ci @spong