-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add support for curved, linear and stepped lines #158896
Conversation
@markov00 Can you review the naming and descriptions? I don't think descriptions are absolutely necessary but would be nice to have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also suggest renaming the Curve type
label to something else.
I feel that Interpolation
or Line interpolation
or Interpolation mode
looks more specific and precise (you can't say that you are using a straight curve, but you have or a straight line or a curved line, IMHO and in my broken English knowledge)
I know that interpolation
is not a daily used word by everyone, but this is anyway a technical software for technical people, and the use of technical words shouldn't be banned
...ns/public/visualizations/xy/xy_config_panel/visual_options_popover/line_curve_definitions.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
@nickofthyme this works great and LGTM from me if @markov00 is ok. Do you want to also add the transition from TSVB to this PR? When the users select Steps yes ![]() and go to Lens we would like the Lens chart to have this curve. It must be as simple as adding when steps equals 1 in the TSVB series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great, I checked the transition from TSVB and also migrating 8.8 SOs. Everything LGTM! The FTs failing are also failing in main so I hope that they are going to skip it soon (I reported this to the team)
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Adds support for `straight`, `smooth` (curved) and `step` (after) curves on line and area charts in Lens.
Summary
Adds support for
straight
,smooth
(curved) andstep
(after) curves on line and area charts in Lens.closes #154410
Checklist