Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap ui in script file rather than inline #15904

Merged
merged 5 commits into from
Feb 5, 2018

Commits on Feb 4, 2018

  1. bootstrap ui in script file rather than inline

    There's no good reason to bootstrap the UI within the browser using an
    inline script tag rather than a separate dynamically created bootstrap
    script.
    
    Having this bootstrapping logic in its own file allows us to cache this
    separately from the main HTML payload, and it is required if we want to
    disable inline scripts entirely.
    epixa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    33bfdfe View commit details
    Browse the repository at this point in the history
  2. cleanup from review 1

    epixa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    d271851 View commit details
    Browse the repository at this point in the history
  3. fix status page bootstrap

    epixa committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    1a250f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. do not require auth for app bootstrap files

    We do not require auth for the rest of our static JS files, and this
    file should not be treated differently than those. That this file is
    created dynamically rather than pulled directly from the file system
    is just an implementation detail.
    epixa committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    c841661 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    baaf7b9 View commit details
    Browse the repository at this point in the history