[ML] Transforms: Fixes max page search size limit #159052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
force-pushed
the
ml-transform-validation
branch
from
7dcd8f2
to
9878244
Compare
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
changed the title
peteharverson
changed the title
walterra
reviewed
Jun 6, 2023
Comment on lines
81
to
97
| // The reducers and utility functions in this file provide the following features: | ||
| // - getDefaultState() | ||
| // Sets up the initial form state. It supports overrides to apply a pre-existing configuration. | ||
| // The implementation of this function is the only one that's specifically required to define | ||
| // the features of the transform edit form. All other functions are generic and could be reused | ||
| // in the future for other forms. | ||
| // | ||
| // - formReducerFactory() / formFieldReducer() | ||
| // These nested reducers take care of updating and validating the form state. | ||
| // | ||
| // - applyFormStateToTransformConfig() (iterates over getUpdateValue()) | ||
| // Once a user hits the update button, these functions take care of extracting the information | ||
| // necessary to create the update request. They take into account whether a field needs to | ||
| // be included at all in the request (for example, if it hadn't been changed). | ||
| // The code is also able to identify relationships/dependencies between form fields. | ||
| // For example, if the `pipeline` field was changed, it's necessary to make the `index` | ||
| // field part of the request, otherwise the update would fail. |
There was a problem hiding this comment.
Suggest to leave this comment section as is in this file because it's about the whole file and not just the moved validator.
There was a problem hiding this comment.
Updated here 7136145 (#159052)
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @qn895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #157975, and updates the max value for max_page_search_size to be 65536.
It also tweaks a previous behavior with the text input which turns values into NaN when typing restricted values.
Before:
https://github.com/elastic/kibana/assets/43350163/4141b73d-0a59-413b-972e-78d80c8194dc
After:
Screen.Recording.2023-06-05.at.13.27.09.mov
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers