Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide create spaces button when limit is reached #159102

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Jun 6, 2023

Resolves #159028
Resolves #159047

Summary

Hide create spaces button when limit is reached.

Screenshot

Spaces-Management-Disabled

Testing

  1. Set the maximum number of allowed spaces to 1
xpack.spaces.maxSpaces: 1
  1. Verify that the create spaces button is hidden and that a callout is displayed

@thomheymann thomheymann added release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Jun 6, 2023
@thomheymann thomheymann marked this pull request as ready for review June 6, 2023 13:52
@thomheymann thomheymann requested a review from a team as a code owner June 6, 2023 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 174.8KB 173.7KB -1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 22.8KB 25.1KB +2.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

References to deprecated APIs

id before after diff
spaces 13 10 -3

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomheymann thomheymann merged commit 0f6eca7 into elastic:main Jun 7, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent creating custom spaces in the serverless offering Hide create spaces when limit reached
5 participants