Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting all SO types #159289

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jun 8, 2023

Summary

Fix #150079

Add support for the * wildcard for by-type export, allowing to more easily export all the exportable SO types

POST /api/saved_objects/_export
{
   types: '*',
}

Release Note

The savedObjects export API now supports exporting all types using the * wildcard. Please refer to the documentation
for more details and examples.

@pgayvallet pgayvallet added release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects Management v8.8.0 labels Jun 8, 2023
Comment on lines +154 to +156
if (types.includes(EXPORT_ALL_TYPES_TOKEN)) {
types = this.#exportableTypes;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change

@pgayvallet pgayvallet marked this pull request as ready for review June 9, 2023 09:24
@pgayvallet pgayvallet requested a review from a team as a code owner June 9, 2023 09:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added v8.9.0 and removed v8.8.0 labels Jun 9, 2023
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧡

@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet enabled auto-merge (squash) June 12, 2023 06:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
@kbn/core-saved-objects-import-export-server-internal 25 26 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 491 495 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit b08c322 into elastic:main Jun 12, 2023
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 12, 2023
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 14, 2023
## Summary

Fix elastic#150079

Add support for the `*` wildcard for by-type export, allowing to more
easily export all the exportable SO types

```
POST /api/saved_objects/_export
{
   types: '*',
}
```

## Release Note

The savedObjects export API now supports exporting all types using the
`*` wildcard. Please refer to the documentation
for more details and examples.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Saved Objects Management release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Saved Objects API] Add possibility to export all saved object types
6 participants