[Dashboard] [Controls] Fix dashboard reset when initial state has no controls #159404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
bug
Heenawter
added
release_note:fix
and removed
release_note:skip
Heenawter
force-pushed
the
fix-no-controls-reset_2023-06-09
branch
from
a685464
to
8353235
Compare
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 9, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @Heenawter |
kibanamachine
added
v8.9.0
backport:skip
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Jun 14, 2023
…controls (elastic#159404) ## Summary Consider taking the following steps: 1. Create a new dashboard and save it 2. Add a control and, without saving, 3. Reset the changes to the dashboard ### Before Before this PR, we were not updating the control group input if the `lastSavedControlGroupInput` was `undefined` (which only happens when a dashboard has **never** been saved with any controls and/or edits to the control group settings) - this caused a problem when trying to reset a dashboard from having controls back to the state where `lastSavedControlGroupInput` was `undefined` because the **dashboard's** input would get updated as expected (i.e. the dashboard would think it no longer has any controls), but the control group's input wouldn't get updated (i.e. the control group would think it **still has** controls). Because of this discrepancy, the control would stick around until you refreshed the dashboard: https://github.com/elastic/kibana/assets/8698078/c9da58dc-3373-493d-9bba-5d2540c19560 ### After Now, after this PR, I fixed this by resetting back to the default control group input if `lastSavedControlGroupInput` is `undefined` on reset: https://github.com/elastic/kibana/assets/8698078/e41838e6-6dbe-47a1-bea7-28f20eddcf80 ### Checklist - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consider taking the following steps:
Before
Before this PR, we were not updating the control group input if the
lastSavedControlGroupInputwasundefined(which only happens when a dashboard has never been saved with any controls and/or edits to the control group settings) - this caused a problem when trying to reset a dashboard from having controls back to the state wherelastSavedControlGroupInputwasundefinedbecause the dashboard's input would get updated as expected (i.e. the dashboard would think it no longer has any controls), but the control group's input wouldn't get updated (i.e. the control group would think it still has controls).Because of this discrepancy, the control would stick around until you refreshed the dashboard:
Screen.Recording.2023-06-09.at.1.52.41.PM.mov
After
Now, after this PR, I fixed this by resetting back to the default control group input if
lastSavedControlGroupInputisundefinedon reset:Screen.Recording.2023-06-09.at.1.55.12.PM.mov
Checklist
For maintainers