Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] TLS Certs page copied from uptime #159541

Merged
merged 3 commits into from Jun 13, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 13, 2023

Summary

TLS Certs page copied from uptime, will only display certificates from synthetics app data !!

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 reopened this Jun 13, 2023
@shahzad31 shahzad31 marked this pull request as ready for review June 13, 2023 12:06
@shahzad31 shahzad31 requested a review from a team as a code owner June 13, 2023 12:06
@paulb-elastic
Copy link
Contributor

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / APM API tests fleet/migration_check.spec.ts cloud no archive Fleet migration check - cloud has_cloud_apm_package_policy with Cloud APM package policy "before all" hook for "should be true when the Cloud APM package policy exists"
  • [job] [logs] FTR Configs #41 / saved objects tagging API saved_object_tagging usage collector data collects the expected data

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1252 1265 +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +9.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 29.1KB 29.3KB +161.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 16 18 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 17 19 +2
securitySolution 493 497 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM, only seeing TLS data from synthetics monitors in the synthetics version.

Uptime TLS

image image

Synthetics TLS

image image

@shahzad31 shahzad31 merged commit d72524a into elastic:main Jun 13, 2023
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2023
@shahzad31 shahzad31 deleted the tls-cert-page branch June 13, 2023 16:21
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023
Co-authored-by: Justin Kambic <jk@elastic.co>
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 13, 2023
Co-authored-by: Justin Kambic <jk@elastic.co>
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this pull request Jun 14, 2023
Co-authored-by: Justin Kambic <jk@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants