Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content management - event annotations #159692

Merged
merged 2 commits into from Jun 15, 2023
Merged

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jun 14, 2023

Summary

content management onboarding for annotations group saved object
Resolve #158774

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.9.0 labels Jun 14, 2023
@ppisljar ppisljar force-pushed the cm/annotations branch 3 times, most recently from 910ad73 to f453295 Compare June 15, 2023 09:02
@ppisljar ppisljar marked this pull request as ready for review June 15, 2023 10:26
@ppisljar ppisljar requested a review from a team as a code owner June 15, 2023 10:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine, I tested it in Chrome and I can save event annotations and load them from the library

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
eventAnnotation 208 211 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventAnnotation 227 234 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotation 110.2KB 110.4KB +210.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
eventAnnotation 32.7KB 33.0KB +305.0B
Unknown metric groups

API count

id before after diff
eventAnnotation 227 234 +7

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 410 414 +4
total +6

References to deprecated APIs

id before after diff
eventAnnotation 47 17 -30

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 493 497 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Event Annotations] individual annotation editing from library
5 participants