Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Add burn rate windows to SLO detail page #159750

Merged
merged 17 commits into from Jun 20, 2023

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jun 14, 2023

Summary

This PR adds a burn rate visualization to the overview tab of the SLO Detail page. This PR also includes a fix for fetching the index pattern fields hook; it uses the DataViews service to fetch the fields instead of the internal API.

image

All good

image

Degrading

image

EVERYTHING IS BURNING 🔥

image

Recovering in the dark

image

No data

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simianhacker simianhacker added release_note:enhancement Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 14, 2023
@simianhacker simianhacker marked this pull request as ready for review June 14, 2023 23:32
@simianhacker simianhacker requested a review from a team as a code owner June 14, 2023 23:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!! Just a few comments, particularly I think we can leverage durationType in the schema to simplify a bit the service.

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM! Wish we can ship that in 8.9

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@simianhacker simianhacker enabled auto-merge (squash) June 20, 2023 20:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 435 439 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 117 122 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +6.0KB
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 117 122 +5

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit c0d3a93 into elastic:main Jun 20, 2023
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 20, 2023
@simianhacker simianhacker deleted the slo-burn-rate-table branch April 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants