New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLO] Add burn rate windows to SLO detail page #159750
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!! Just a few comments, particularly I think we can leverage durationType
in the schema to simplify a bit the service.
x-pack/plugins/observability/public/hooks/slo/use_fetch_index_pattern_fields.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/server/services/slo/get_burn_rates.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/server/services/slo/get_burn_rates.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/hooks/slo/use_fetch_slo_burn_rates.ts
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/slo_details/components/slo_details.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM! Wish we can ship that in 8.9
…he background is SUCCESS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
This PR adds a burn rate visualization to the overview tab of the SLO Detail page. This PR also includes a fix for fetching the index pattern fields hook; it uses the DataViews service to fetch the fields instead of the internal API.
All good
Degrading
EVERYTHING IS BURNING 🔥
Recovering in the dark
No data