Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Visualize] Removes wrong padding on the dashboard #159992

Merged
merged 2 commits into from Jun 20, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 20, 2023

Summary

Closes #159942

If the height of a partition chart exceeds 1000px paddings are added, reducing the chart size.
This is caused due to this piece of code #122420

This was added for the aggbased editor to reduce a bit the pie size (otherwise it was taking the full container size and the pie was huge)

Although we want this, we don't want this to be applied in dashboards or lens editor. This PR is fixing this by adding the paddings only on the agg based editor level

In agg based editor
image

Dashboard with very tall treemap, no paddings
image

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/chart-expressions-common 6 8 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 31.1KB 31.2KB +90.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionPartitionVis 25.5KB 25.7KB +188.0B
Unknown metric groups

API count

id before after diff
@kbn/chart-expressions-common 9 11 +2

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting labels Jun 20, 2023
@stratoula stratoula marked this pull request as ready for review June 20, 2023 11:55
@stratoula stratoula requested a review from a team as a code owner June 20, 2023 11:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome, works as expected. The paddings are fixed in Dashboard and on Canvas 👌🏼

@stratoula stratoula merged commit c0e43db into elastic:main Jun 20, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Treemap shows excessive padding if its height is greater then 1000px
5 participants