Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] adds missing dependency fieldFormats in kibana.jsonc #160445

Merged
merged 4 commits into from
Jun 23, 2023
Merged

[Security Solution] adds missing dependency fieldFormats in kibana.jsonc #160445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba6485d
adds missing dependency in kibana.jsonc
dhurley14 Jun 23, 2023
8e6e572
Merge branch 'main' into sec-sol-missing-dep-field-formats
dhurley14 Jun 23, 2023
2a27616
adds warning to StartPlugins
dhurley14 Jun 23, 2023
baf0fd2
Merge branch 'sec-sol-missing-dep-field-formats' of github.com:dhurle…
dhurley14 Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 4 additions & 8 deletions x-pack/plugins/security_solution/kibana.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
"id": "securitySolution",
"server": true,
"browser": true,
"configPath": [
"xpack",
"securitySolution"
],
"configPath": ["xpack", "securitySolution"],
"requiredPlugins": [
"actions",
"alerting",
Expand All @@ -25,6 +22,7 @@
"embeddable",
"eventLog",
"features",
"fieldFormats",
"guidedOnboarding",
"inspector",
"kubernetesSecurity",
Expand All @@ -43,7 +41,7 @@
"files",
"controls",
"savedObjectsManagement",
"stackConnectors",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONC is the wild west with syntax, apparently 😅

"stackConnectors"
],
"optionalPlugins": [
"cloudExperiments",
Expand Down Expand Up @@ -71,8 +69,6 @@
"unifiedSearch",
"cloudChat"
],
"extraPublicDirs": [
"common"
]
"extraPublicDirs": ["common"]
}
}
9 changes: 9 additions & 0 deletions x-pack/plugins/security_solution/public/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ export interface SetupPlugins {
ml?: MlPluginSetup;
}

/**
* IMPORTANT - PLEASE READ: When adding new plugins to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* security solution, please ensure you add that plugin
* name to the kibana.jsonc file located in ../kibana.jsonc
*
* Without adding the plugin name there, the plugin will not
* fulfill at runtime, despite the types showing up correctly
* in the code.
*/
export interface StartPlugins {
cases: CasesUiStart;
data: DataPublicPluginStart;
Expand Down