[Cases] Fix bug in cases bulk action in the alerts table #160526

cnasikas · 2023-06-26T14:25:08Z

Summary

In 8.8 we move the logic of the cases action from solutions to the alerts table. A bug was introduced when you try to attach an alert to a new case through the cases modal.

Before

Screen.Recording.2023-06-26.at.5.26.32.PM.mov

Error in console

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'id')
    at getAttachments (use_bulk_actions.ts:100:1)
    at use_cases_add_to_existing_case_modal.tsx:52:1
    at onRowClick (use_cases_add_to_existing_case_modal.tsx:107:1)
    at all_cases_selector_modal.tsx:36:1
    at all_cases_list.tsx:208:1
    at table_filters.tsx:128:1
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1)
    at invokeGuardedCallback (react-dom.development.js:4056:1)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4070:1)

After

Screen.Recording.2023-06-26.at.5.25.41.PM.mov

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

Release notes

Fix a bug in the alerts table where you cannot create a new case when attaching alerts to a case from the cases modal

elasticmachine · 2023-06-26T14:31:53Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-06-26T14:31:55Z

Pinging @elastic/response-ops-cases (Feature:Cases)

adcoelho

Tested and works fine 👍

adcoelho · 2023-06-26T14:44:08Z

...ugins/triggers_actions_ui/public/application/sections/alerts_table/hooks/use_bulk_actions.ts

@@ -146,6 +146,10 @@ export const useBulkAddToCaseActions = ({
            onClick: (alerts?: TimelineItem[]) => {
              selectCaseModal.open({
                getAttachments: ({ theCase }) => {
+                  if (theCase == null) {
+                    return alerts ? casesService?.helpers.groupAlertsByRule(alerts) ?? [] : [];


can alerts actually be missing? If this is triggered via the bulk actions it shouldn't ever, right?

I don't remember why but I followed the pattern used in the other action. Maybe there is a reason. I agree with you. It shouldn't be undefined.

adcoelho · 2023-06-26T14:48:04Z

...triggers_actions_ui/public/application/sections/alerts_table/hooks/use_bulk_actions.test.tsx

@@ -124,6 +126,55 @@ describe('bulk action hooks', () => {
      expect(openExistingCase).toHaveBeenCalled();
    });

+    it('should open the flyout from the case modal', async () => {


An e2e test for this would also be nice if there is time. Looked a bit for them but dunno if there even are any regarding bulk actions in the alerts table.

I don't think we have. Do you mind if we do it on another PR? I have this issue to track it #160240.

kibana-ci · 2023-06-26T15:30:37Z

💚 Build Succeeded

Buildkite Build
Commit: 1cb1cdd

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+100.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	416	420	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	497	501	+4
total			+6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

) ## Summary In 8.8 we move the logic of the cases action from solutions to the alerts table. A bug was introduced when you try to attach an alert to a new case through the cases modal. Before https://github.com/elastic/kibana/assets/7871006/771a5d28-e279-43d4-b72e-2dfb6689bae6 Error in `console` ``` Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'id') at getAttachments (use_bulk_actions.ts:100:1) at use_cases_add_to_existing_case_modal.tsx:52:1 at onRowClick (use_cases_add_to_existing_case_modal.tsx:107:1) at all_cases_selector_modal.tsx:36:1 at all_cases_list.tsx:208:1 at table_filters.tsx:128:1 at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1) at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1) at invokeGuardedCallback (react-dom.development.js:4056:1) at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4070:1) ``` After https://github.com/elastic/kibana/assets/7871006/89e44018-49cf-41f7-8e07-01c6eb197624 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release notes Fix a bug in the alerts table where you cannot create a new case when attaching alerts to a case from the cases modal (cherry picked from commit df21ba0)

kibanamachine · 2023-06-26T15:39:30Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8
✅	8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…) (#160542) # Backport This will backport the following commits from `main` to `8.8`: - [[Cases] Fix bug in cases bulk action in the alerts table (#160526)](#160526)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

…) (#160543) # Backport This will backport the following commits from `main` to `8.9`: - [[Cases] Fix bug in cases bulk action in the alerts table (#160526)](#160526)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

mistic · 2023-06-29T20:40:13Z

This PR didn't make it into the latest build candidate of v8.8.2. Updating the labels.

Fix bug

1cb1cdd

cnasikas added Feature:Cases Cases feature v8.9.0 v8.8.2 v8.10.0 labels Jun 26, 2023

cnasikas self-assigned this Jun 26, 2023

cnasikas added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 26, 2023

cnasikas marked this pull request as ready for review June 26, 2023 14:31

cnasikas requested a review from a team as a code owner June 26, 2023 14:31

cnasikas added the release_note:fix label Jun 26, 2023

adcoelho approved these changes Jun 26, 2023

View reviewed changes

adcoelho reviewed Jun 26, 2023

View reviewed changes

jonathan-buttner approved these changes Jun 26, 2023

View reviewed changes

cnasikas merged commit df21ba0 into elastic:main Jun 26, 2023
37 checks passed

cnasikas deleted the fix_cases_bulk_actions branch June 26, 2023 15:32

kibanamachine mentioned this pull request Jun 26, 2023

[8.8] [Cases] Fix bug in cases bulk action in the alerts table (#160526) #160542

Merged

kibanamachine mentioned this pull request Jun 26, 2023

[8.9] [Cases] Fix bug in cases bulk action in the alerts table (#160526) #160543

Merged

mistic removed the v8.8.2 label Jun 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Fix bug in cases bulk action in the alerts table #160526

[Cases] Fix bug in cases bulk action in the alerts table #160526

cnasikas commented Jun 26, 2023 •

edited by kibanamachine

elasticmachine commented Jun 26, 2023

elasticmachine commented Jun 26, 2023

adcoelho left a comment

adcoelho Jun 26, 2023

cnasikas Jun 26, 2023

adcoelho Jun 26, 2023 •

edited

cnasikas Jun 26, 2023

kibana-ci commented Jun 26, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Jun 26, 2023

mistic commented Jun 29, 2023

[Cases] Fix bug in cases bulk action in the alerts table #160526

[Cases] Fix bug in cases bulk action in the alerts table #160526

Conversation

cnasikas commented Jun 26, 2023 • edited by kibanamachine

Summary

Checklist

For maintainers

Release notes

elasticmachine commented Jun 26, 2023

elasticmachine commented Jun 26, 2023

adcoelho left a comment

Choose a reason for hiding this comment

adcoelho Jun 26, 2023

Choose a reason for hiding this comment

cnasikas Jun 26, 2023

Choose a reason for hiding this comment

adcoelho Jun 26, 2023 • edited

Choose a reason for hiding this comment

cnasikas Jun 26, 2023

Choose a reason for hiding this comment

kibana-ci commented Jun 26, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Jun 26, 2023

💚 All backports created successfully

Questions ?

mistic commented Jun 29, 2023

cnasikas commented Jun 26, 2023 •

edited by kibanamachine

adcoelho Jun 26, 2023 •

edited