Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Update connector integrations for 8.9 #160532

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Jun 26, 2023

Summary

This updates connector tiles for Enterprise Search to bring them in line with 8.9.

Screenshot 2023-06-26 at 16 26 40 Screenshot 2023-06-26 at 16 25 04 Screenshot 2023-06-26 at 16 24 40

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0 labels Jun 26, 2023
@sphilipse sphilipse requested review from a team as code owners June 26, 2023 14:47
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@sloanelybutsurely sloanelybutsurely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

packages/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved
connectorsContentExtraction: `${ENTERPRISE_SEARCH_DOCS}connectors-content-extraction.html`,
connectorsDropbox: `${ENTERPRISE_SEARCH_DOCS}connectors-content-extraction.html`,
connectorsContentExtraction: `${ENTERPRISE_SEARCH_DOCS}connectors-dropbox.html`,
connectorsGithub: `${ENTERPRISE_SEARCH_DOCS}connectors-github.html`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the Github connector land in time for 8.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait actually hold on, let me double check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay removed it again because it's not ready yet

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

leemthompo
leemthompo previously approved these changes Jun 26, 2023
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doclinks LGTM

@leemthompo
Copy link
Contributor

@sphilipse hang on sorry that GH page doesn't exist yet. I'll open a PR.

@leemthompo leemthompo dismissed their stale review June 26, 2023 16:17

GH link not live yet

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doclinks LGTM again!

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet change LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2143 2146 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
customIntegrations 255 252 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.5MB 2.5MB +3.9KB
lists 143.1KB 143.2KB +102.0B
total +4.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 361.6KB 361.7KB +102.0B
customIntegrations 10.4KB 10.3KB -42.0B
enterpriseSearch 37.8KB 38.0KB +270.0B
total +330.0B
Unknown metric groups

API count

id before after diff
customIntegrations 274 271 -3

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 4d812c1 into elastic:main Jun 27, 2023
22 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 27, 2023
…0532)

## Summary

This updates connector tiles for Enterprise Search to bring them in line
with 8.9.

<img width="1032" alt="Screenshot 2023-06-26 at 16 26 40"
src="https://github.com/elastic/kibana/assets/94373878/a222a2a3-17ad-4e72-8ce8-57e09d89d05e">
<img width="1035" alt="Screenshot 2023-06-26 at 16 25 04"
src="https://github.com/elastic/kibana/assets/94373878/3ce1e78c-b4fe-404b-b314-e02f3d6f439e">
<img width="1086" alt="Screenshot 2023-06-26 at 16 24 40"
src="https://github.com/elastic/kibana/assets/94373878/14dd6ca5-875f-4c2d-9408-a2fa15abbbec">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4d812c1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 27, 2023
) (#160651)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Enterprise Search] Update connector integrations for 8.9
(#160532)](#160532)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-27T15:23:09Z","message":"[Enterprise
Search] Update connector integrations for 8.9 (#160532)\n\n##
Summary\r\n\r\nThis updates connector tiles for Enterprise Search to
bring them in line\r\nwith 8.9.\r\n\r\n<img width=\"1032\"
alt=\"Screenshot 2023-06-26 at 16 26
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/a222a2a3-17ad-4e72-8ce8-57e09d89d05e\">\r\n<img
width=\"1035\" alt=\"Screenshot 2023-06-26 at 16 25
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/3ce1e78c-b4fe-404b-b314-e02f3d6f439e\">\r\n<img
width=\"1086\" alt=\"Screenshot 2023-06-26 at 16 24
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/14dd6ca5-875f-4c2d-9408-a2fa15abbbec\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4d812c1d24c74e3dfb09f42a1953de8e17fb969c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.9.0","v8.10.0"],"number":160532,"url":"#160532
Search] Update connector integrations for 8.9 (#160532)\n\n##
Summary\r\n\r\nThis updates connector tiles for Enterprise Search to
bring them in line\r\nwith 8.9.\r\n\r\n<img width=\"1032\"
alt=\"Screenshot 2023-06-26 at 16 26
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/a222a2a3-17ad-4e72-8ce8-57e09d89d05e\">\r\n<img
width=\"1035\" alt=\"Screenshot 2023-06-26 at 16 25
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/3ce1e78c-b4fe-404b-b314-e02f3d6f439e\">\r\n<img
width=\"1086\" alt=\"Screenshot 2023-06-26 at 16 24
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/14dd6ca5-875f-4c2d-9408-a2fa15abbbec\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4d812c1d24c74e3dfb09f42a1953de8e17fb969c"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#160532
Search] Update connector integrations for 8.9 (#160532)\n\n##
Summary\r\n\r\nThis updates connector tiles for Enterprise Search to
bring them in line\r\nwith 8.9.\r\n\r\n<img width=\"1032\"
alt=\"Screenshot 2023-06-26 at 16 26
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/a222a2a3-17ad-4e72-8ce8-57e09d89d05e\">\r\n<img
width=\"1035\" alt=\"Screenshot 2023-06-26 at 16 25
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/3ce1e78c-b4fe-404b-b314-e02f3d6f439e\">\r\n<img
width=\"1086\" alt=\"Screenshot 2023-06-26 at 16 24
40\"\r\nsrc=\"https://github.com/elastic/kibana/assets/94373878/14dd6ca5-875f-4c2d-9408-a2fa15abbbec\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4d812c1d24c74e3dfb09f42a1953de8e17fb969c"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
rshen91 pushed a commit that referenced this pull request Jun 28, 2023
## Summary

This updates connector tiles for Enterprise Search to bring them in line
with 8.9.

<img width="1032" alt="Screenshot 2023-06-26 at 16 26 40"
src="https://github.com/elastic/kibana/assets/94373878/a222a2a3-17ad-4e72-8ce8-57e09d89d05e">
<img width="1035" alt="Screenshot 2023-06-26 at 16 25 04"
src="https://github.com/elastic/kibana/assets/94373878/3ce1e78c-b4fe-404b-b314-e02f3d6f439e">
<img width="1086" alt="Screenshot 2023-06-26 at 16 24 40"
src="https://github.com/elastic/kibana/assets/94373878/14dd6ca5-875f-4c2d-9408-a2fa15abbbec">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants