Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Reduces rerenders and multiple fetches of source index on transform wizard load. #160979

Merged
merged 2 commits into from Jul 10, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jun 30, 2023

Summary

Adds checks to avoid unnecessary initial rerenders and refetches of data when loading the transform wizard. This reduces rerenders from 14 to 11 and more importantly the request to fetch index data is triggered only once instead of three times. One of the requests even triggered an error which could briefly trigger a callout on slower connections.

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:fix :ml Feature:Transforms ML transforms v8.10.0 labels Jun 30, 2023
@walterra walterra requested review from darnautov and qn895 June 30, 2023 11:01
@walterra walterra requested a review from a team as a code owner June 30, 2023 11:01
@walterra walterra self-assigned this Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jun 30, 2023

Changes LGTM 🎉

@elastic elastic deleted a comment from Valecia2023 Jul 10, 2023
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 404.5KB 404.6KB +68.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit fc4edd6 into elastic:main Jul 10, 2023
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 10, 2023
@walterra walterra deleted the ml-transform-improve-rerenders branch July 10, 2023 10:37
@peteharverson peteharverson changed the title [ML] Transforms: Reduce rerenders and multiple fetches of source index on transform wizard load. [ML] Transforms: Reduces rerenders and multiple fetches of source index on transform wizard load. Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml release_note:fix v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants