Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loading of APM alert table #161134

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Fix infinite loading of APM alert table #161134

merged 3 commits into from
Jul 4, 2023

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Jul 3, 2023 •
edited by kibanamachine
Loading

Fixes #161095

Summary

This PR fixes triggering and immediately canceling /bsearch requests infinitely.

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.8.3 labels Jul 3, 2023
@maryam-saeidi maryam-saeidi self-assigned this Jul 3, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

maryam-saeidi
maryam-saeidi commented Jul 3, 2023
View reviewed changes
x-pack/test/functional/apps/apm/correlations/failed_transaction_correlations.ts
await PageObjects.timePicker.setCommonlyUsedTime('Last_15 minutes');

// Should show no data message
await retry.try(async () => {
Copy link
Member Author

@maryam-saeidi maryam-saeidi Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a small test that fails before the fix to catch similar issues in future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB +87.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi marked this pull request as ready for review July 3, 2023 21:43
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner July 3, 2023 21:43
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

kpatticha
kpatticha approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix 🙏

@maryam-saeidi maryam-saeidi merged commit 023b23f into elastic:main Jul 4, 2023
23 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 4, 2023
@maryam-saeidi
Fix infinite loading of APM alert table (elastic#161134)
889b7b4 
Fixes elastic#161095

## Summary

This PR fixes triggering and immediately canceling /bsearch requests
infinitely.

(cherry picked from commit 023b23f)
This was referenced Jul 4, 2023
Closed
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 4, 2023
@maryam-saeidi
Fix infinite loading of APM alert table (elastic#161134)
7eb86b7 
Fixes elastic#161095

## Summary

This PR fixes triggering and immediately canceling /bsearch requests
infinitely.

(cherry picked from commit 023b23f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 4, 2023
@kibanamachine @maryam-saeidi
[8.9] Fix infinite loading of APM alert table (#161134) (#161160)
2c55fd5 
# Backport

This will backport the following commits from `main` to `8.9`:
- [Fix infinite loading of APM alert table
(#161134)](#161134)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-07-04T09:54:02Z","message":"Fix
infinite loading of APM alert table (#161134)\n\nFixes #161095\r\n\r\n##
Summary\r\n\r\nThis PR fixes triggering and immediately canceling
/bsearch
requests\r\ninfinitely.","sha":"023b23f2a6a16612e48300494e66836d2c49c785","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:APM","backport:prev-minor","v8.10.0","v8.8.3"],"number":161134,"url":"#161134
infinite loading of APM alert table (#161134)\n\nFixes #161095\r\n\r\n##
Summary\r\n\r\nThis PR fixes triggering and immediately canceling
/bsearch
requests\r\ninfinitely.","sha":"023b23f2a6a16612e48300494e66836d2c49c785"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#161134
infinite loading of APM alert table (#161134)\n\nFixes #161095\r\n\r\n##
Summary\r\n\r\nThis PR fixes triggering and immediately canceling
/bsearch
requests\r\ninfinitely.","sha":"023b23f2a6a16612e48300494e66836d2c49c785"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
@dgieselaar dgieselaar mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:fix Team:APM All issues that need APM UI Team support v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AO] Infinite alert table loading
6 participants
@maryam-saeidi @apmmachine @kibana-ci @elasticmachine @kibanamachine @kpatticha