Bugfix: #16092 Spy Panel Does not work if Legend is set to Bottom

[varunsharma27]

Bugfix: #16092 Spy Panel Does not work if Legend is set to Bottom

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[thomasneirynck]

jenkins, test this

[varunsharma27]

The PR appears to have failed a test but I'm unable to fetch details:

HTTP ERROR 404
Problem accessing /job/elastic-kibana-pull-request/14880/. Reason:

Not Found

However I see no reason for a failed build since this is the same solution as what's being used in master:
https://github.com/elastic/kibana/blob/master/src/ui/public/visualize/visualize.less#L85
Perhaps we are dealing with an implementation dependent test case? Any further action that could be taken from my side to mitigate the issue?

[timroes]

I guess we rather had some issues with Jenkins, that caused the failure.

[timroes]

Jenkins, test this

[ppisljar]

jenkins, test this

[ppisljar]

the selenium test failed on:

fail: "visualize app visualize app gauge chart should show Split Gauges"
15:19:30 03:19:30.801        │        tryForTime timeout: Error: expected [ 'win 8', 'win xp', 'win 7', 'ios', 'osx' ] to sort of equal [ '', '', '', '', '' ]

if you can rebase i think this will be solved, however i am wondering if the same problem is also present in 6.x kibana ? if that is the case you should open a PR against master, and we will backport to earlier versions.

thanks

[varunsharma27]

This given issue does not exist in 6.x. If you can let me know a bit about the failing test case then maybe I can figure out a way to rectify the issue, it has to be something minor though as all I'm doing is setting the z-index of spyPanel toggle a little higher so that it does not get under Legend.

[ppisljar]

as mentioned above, rebasing should solve it (it was an issue with out test which should be now resolved)

[varunsharma27]

Rebased the branch.

[ppisljar]

jenkins, test this

[ppisljar]

fail: "visualize app visualize app vector map should show results after clicking play (join on states)"

jenkins, test this

[thomasneirynck]

thanks @varundbest

for reference sake: this is actually fixed in 599c8c4, so this is why this PR is opened against 5.6.

[ppisljar]

LGTM