Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Unskip mocked response actions history cypress test #161533

Merged
merged 4 commits into from Jul 11, 2023
Merged

[Security Solution][Endpoint] Unskip mocked response actions history cypress test #161533

merged 4 commits into from Jul 11, 2023

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jul 10, 2023 •
edited

Summary

Unskip test that was timing out at indexing test hosts. The timeout has since been increased in /pull/159518

It was added in /pull/157777 and skipped in /pull/156933 thus should be backported to 8.9.0.

Note: We can't backport it to 8.8 as the timeout is not increased on that branch.

@ashokaditya ashokaditya self-assigned this Jul 10, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.9.0 v8.8.1 labels Jul 10, 2023
@ashokaditya ashokaditya marked this pull request as ready for review July 10, 2023 11:11
@ashokaditya ashokaditya requested a review from a team as a code owner July 10, 2023 11:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@ashokaditya ashokaditya requested review from kevinlog and removed request for dasansol92 July 10, 2023 11:12
@ashokaditya ashokaditya enabled auto-merge (squash) July 11, 2023 11:59
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / Add, copy comments in different exceptions type and validate sharing them between users Rule exceptions Add comment on a new exception, add another comment has unicode from a different user and copy to clipboard
  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data enables a job

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit f6f5986 into elastic:main Jul 11, 2023
30 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.8 Backport failed because of merge conflicts
❌ 8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 161533

Questions ?

Please refer to the Backport tool documentation

@ashokaditya ashokaditya deleted the task/dw-unskip-cypress-test branch July 11, 2023 14:00
ashokaditya added a commit that referenced this pull request Jul 12, 2023
@ashokaditya
[Security Solution][Endpoint] Unskip mocked response actions history …
d522ad1 
…cypress test (#161533)

## Summary

Unskip test that was timing out at indexing test hosts. The timeout has
since been increased in /pull/159518

It was added in /pull/157777 and skipped in
/pull/156933 thus should be backported to `8.8.1` and
`8.9.0`

(cherry picked from commit f6f5986)

# Conflicts:
#	x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/reponse_actions_history.cy.ts
ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Jul 12, 2023
@ashokaditya
[Security Solution][Endpoint] Unskip mocked response actions history …
050c794 
…cypress test (elastic#161533)

## Summary

Unskip test that was timing out at indexing test hosts. The timeout has
since been increased in elastic/pull/159518

It was added in elastic/pull/157777 and skipped in
elastic/pull/156933 thus should be backported to `8.8.1` and
`8.9.0`

(cherry picked from commit f6f5986)

# Conflicts:
#	x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/reponse_actions_history.cy.ts
@ashokaditya ashokaditya mentioned this pull request Jul 12, 2023
Closed
@ashokaditya
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 21, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 161533 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

@kevinlog kevinlog kevinlog approved these changes

Assignees

@ashokaditya ashokaditya

Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ashokaditya @elasticmachine @kibana-ci @kibanamachine @tomsonpl @gergoabraham @kevinlog