Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Management] Update pager with new props in Index Pattern Creation #16195

Merged
merged 2 commits into from Jan 22, 2018
Merged

[Management] Update pager with new props in Index Pattern Creation #16195

merged 2 commits into from Jan 22, 2018

Conversation

chrisronline
Copy link
Contributor

Fixes #16192

A fun bug! The IndicesList component's lifecycle wasn't properly managed with the usage of the Pager utility. If we receive a prop change with more or less indices, we need to update the pager.

Note: The snapshots for IndicesList are growing too much. Created #16194 to track

@chrisronline chrisronline self-assigned this Jan 22, 2018
bmcconaghy
bmcconaghy approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjcenizal
cjcenizal approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisronline chrisronline merged commit 7b3a2f1 into elastic:master Jan 22, 2018
@chrisronline chrisronline deleted the fix/16192 branch January 22, 2018 17:54
@chrisronline chrisronline mentioned this pull request Jan 22, 2018
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 22, 2018
@chrisronline
[Management] Update pager with new props in Index Pattern Creation (e…
5a2f1aa 
…lastic#16195)

* Update pager with new props

* Update snapshot description
@chrisronline chrisronline mentioned this pull request Jan 22, 2018
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 22, 2018
@chrisronline
[Management] Update pager with new props in Index Pattern Creation (e…
4b45460 
…lastic#16195)

* Update pager with new props

* Update snapshot description
chrisronline added a commit that referenced this pull request Jan 22, 2018
@chrisronline
[Management] Update pager with new props in Index Pattern Creation (#…
b1b3486 
…16195) (#16207)

* Update pager with new props

* Update snapshot description
chrisronline added a commit that referenced this pull request Jan 22, 2018
@chrisronline
[Management] Update pager with new props in Index Pattern Creation (#…
d58b38a 
…16195) (#16206)

* Update pager with new props

* Update snapshot description
@chrisronline
Copy link
Contributor Author

Backport:

6.x: d58b38a
6.2: b1b3486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Assignees

@chrisronline chrisronline

Labels
review v6.2.0 v6.2.1 v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisronline @cjcenizal @bmcconaghy