Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Uses model supplied mask token for testing trained models #162168

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 18, 2023

Fixes #159577

Using the mask_token property from the model config for testing the model.
This is shown in the input placeholder text, in the input validation and for displaying the results.

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +228.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the xlm-roberta-base model using the <mask> token and LGTM.

@jgowdyelastic jgowdyelastic merged commit 3524da7 into elastic:main Jul 20, 2023
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 20, 2023
dgieselaar pushed a commit to dgieselaar/kibana that referenced this pull request Jul 23, 2023
Fixes elastic#159577

Using the `mask_token` property from the model config for testing the
model.
This is shown in the input placeholder text, in the input validation and
for displaying the results.

<img width="433" alt="image"
src="https://github.com/elastic/kibana/assets/7405507/bc63f9e6-a3d5-402c-a451-8d80b758acbc">
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
Fixes elastic#159577

Using the `mask_token` property from the model config for testing the
model.
This is shown in the input placeholder text, in the input validation and
for displaying the results.

<img width="433" alt="image"
src="https://github.com/elastic/kibana/assets/7405507/bc63f9e6-a3d5-402c-a451-8d80b758acbc">
@peteharverson peteharverson changed the title [ML] Using model supplied mask token [ML] Uses model supplied mask token for testing trained models Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:fix v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Support testing fill mask models that do not use the [MASK] token
5 participants